Bug #96813: BeforeRedirectEvent is not useful at all because it accepts no arguments and the return value is ignored - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Bug #96813

closed

BeforeRedirectEvent is not useful at all because it accepts no arguments and the return value is ignored

Added by S P over 2 years ago. Updated 2 months ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

felogin

Target version:

Start date:

2022-02-10

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Steps to reproduce:

Register your event class at the BeforeRedirectEvent
Let felogin trigger a redirect
the event gets fired
Problem: you have no way to do anything meaningful because the result value is not returned and no objects (e.g. the LoginConroller) are passed as argument.

The event gets the redirect URL and the login-type passed as parameter. But you neither can return a changed redirect URL nor change the calling controller (e.g. to inject another redirect URL).

The Event should provide at least one way to actually use the result from the event.

I flagged this as a bug, not as a feature, because the feature itself (the event) is already there, but it's just dead code.

Related issues 4 (0 open — 4 closed)

Related to TYPO3 Core - Bug #92068: felogin (extbase) redirect from GET/POST is not working properly

Closed

2020-08-21

Actions

Related to TYPO3 Core - Bug #90157: missing possibility to send return_url Parameter with 403 standard errorhandler

Closed

2020-01-20

Actions

Related to TYPO3 Core - Bug #91844: felogin Redirect to referer is not working at all with Site config 403 errorHandler

Closed

2020-07-23

Actions

Related to TYPO3 Core - Epic #96814: Totally broken felogin redirect mechanism

Closed

2022-02-10

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by S P over 2 years ago

Related to Bug #92068: felogin (extbase) redirect from GET/POST is not working properly added

Actions

Copy link

Updated by S P over 2 years ago

Reproducing step 2 should be "Let felogin trigger a ~~releoad~~ redirect", of course.

Actions

Copy link

Updated by S P over 2 years ago

Related to Bug #90157: missing possibility to send return_url Parameter with 403 standard errorhandler added

Actions

Copy link

Updated by S P over 2 years ago

Related to Bug #91844: felogin Redirect to referer is not working at all with Site config 403 errorHandler added

Actions

Copy link

Updated by S P over 2 years ago

Related to Epic #96814: Totally broken felogin redirect mechanism added

Actions

Copy link

Updated by S P over 2 years ago

For people with similar problems:

In the event I do this:

$myChangedRedirectUrl = $event->getRedirectUrl();

// here change $myChangedRedirectUrl

\header('Location: ' . $myChangedRedirectUrl);
throw new \TYPO3\CMS\Extbase\Mvc\Exception\StopActionException();

This is totally off-framework, but afaics the only way to achieve anything with this event. Feels totally ugly and hacky.

Actions

Copy link

Updated by Oliver Hader over 2 years ago

BeforeRedirectEvent does work, I just does not match with your expectations.

adding new setters/getters for new modifiedRedirectUrl property might be fine
and also fine using $event->getModifiedRedirectUrl() ?? $event->getRedirectUrl() when redirecting in https://github.com/TYPO3/typo3/blob/58558fee9ad4897016bd9a21a02a1c0a07595f6a/typo3/sysext/felogin/Classes/Controller/LoginController.php#L232

The original change in issue #88740 has been merged two years ago for TYPO3 v10.4.0.

Actions

Copy link

Updated by S P about 2 years ago

Subject changed from BeforeRedirectEvent is not working to BeforeRedirectEvent is not useful at all because it accepts no arguments and the return value is ignored
Description updated (diff)

Actions

Copy link

Updated by Benni Mack over 1 year ago

I'm fine changing this. Reading through the passive aggressive rants in this issue took me longer than the actual fix.

Actions

Copy link

#10

Updated by Gerrit Code Review over 1 year ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78135

Actions

Copy link

#11

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78059

Actions

Copy link

#12

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78059

Actions

Copy link

#13

Updated by Benni Mack over 1 year ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 2522a9c4d8dc9d27ff6e6c8b347a5f039548195f.

Actions

Copy link

#14

Updated by Gerrit Code Review over 1 year ago

Status changed from Resolved to Under Review

Patch set 3 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78059

Actions

Copy link

#15

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78059

Actions

Copy link

#16