Bug #96929: TCA / TCA overrides with variable leaks - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #96929

closed

TCA / TCA overrides with variable leaks

Added by Mathias Brodala about 2 years ago. Updated over 1 year ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Code Cleanup

Target version:

12 LTS

Start date:

2022-02-16

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

All TCA and TCA overrides files are included without any scoping. This means that variables defined in these files can leak into the following files.

Also all variables defined in ExtensionManagementUtility::buildBaseTcaFromSingleFiles() exist in TCA and TCA override files and could even be manipulated.

See https://github.com/TYPO3/typo3/blob/35f7bbb381514efd483b9bfe1570229fc454dd8f/typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php#L1477

Possible solution: wrap the require calls for TCA / TCA override files with a closure.

Actions

Copy link

Updated by Christian Kuhn about 2 years ago

good idea.

Actions

Copy link

Updated by Gerrit Code Review about 2 years ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73731

Actions

Copy link

Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73731

Actions

Copy link

Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73731

Actions

Copy link

Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73731

Actions

Copy link

Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73731

Actions

Copy link

Updated by Gerrit Code Review about 2 years ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73731

Actions

Copy link

Updated by Gerrit Code Review about 2 years ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73731

Actions

Copy link

Updated by Gerrit Code Review about 2 years ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73731

Actions

Copy link

#10

Updated by Gerrit Code Review about 2 years ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73731

Actions

Copy link

#11

Updated by Gerrit Code Review about 2 years ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73731

Actions

Copy link

#12