TYPO3 Core

I might understand you wrong, but I have a question back to you.

Let us say you have a sys-folder like the following:

• Sys-folder
  • News Record 1 (Active)
  • News Record 2 (Hidden)

When you then click hide on the sys-folder, it would be like this: (from how I understand you)

• Sys-folder (hidden)
  • News Record 1 (hidden)
  • News Record 2 (Hidden)

What should then happen when I activate the sys-folder again? Should all in the sys-folder then be active? Then you are reaching a state that you didn't have before, hiding it.

You misunderstood. Disabling a sysfolder should not disable all containing records via backend but should hide them in frontend.
In my opinion the sysfolder's state (enabled or disabled) should be taken in account when performing queries on records.

Currently an SQL query performed by extbase with common enabledFields and storagePid looks kind of like this:

SELECT tx_extkey_somerecord .* FROM tx_extkey_somerecord WHERE tx_extkey_somerecord.pid=STORAGE-PID AND tx_extkey_somerecord.deleted=0 AND tx_extkey_somerecord.hidden=0;

As you see, there are no checks included to query the current sysfolder's state.
So it should be changed to something like this:

SELECT tx_extkey_somerecord.* FROM tx_extkey_somerecord LEFT JOIN pages ON pages.uid=tx_extkey_somerecord.pid WHERE tx_extkey_somerecord.pid=STORAGE-PID AND tx_extkey_somerecord.deleted=0 AND tx_extkey_somerecord.hidden=0 AND pages.deleted=0 AND pages.hidden=0;

I agree that the current behaviour is somehow unexpected. Either the checkbox hidden must be removed from sys_folders or it must fulfill a reasion. I agree that all records which are below a hidden sys_folder should be removed in the FE rendering.

However there are also multiple questions to be answered:

• Is it worth this totally breaking behaviour (imo yes)
• What about recursions like Hidden Sysfolder/Non Hidden Sysfolder/A Record. Should this be hidden as well?
• What about Menus: I guess those should be hidden as well?
• What about the admin panel feature "show hidden records": Should that respect such stuff too?
• What about the content element "shortcut" or TypoScript cObj "RECORDS" which renders a content element being on a hidden page?
• What about the content element "shortcut" or TypoScript cObj "RECORDS" which renders a content element being on a non hidden page but its parent page is hidden?

Good points you brought up Georg.

I think parent sysfolders should be recognized as well. But thinking about pages, the behavoir should be the same, e.g. if you disable the rootpage the whole website would be unaccessible. Quite a big change though.

And yes, this behavior should cover all situations where TYPO3 collects records from sysfolders (or pages) in my opinion.
Not a no-brainer at all :(

see https://decisions.typo3.org/t/behaviour-of-hidden-of-pages/780/