Bug #98094: Abort commit if commit message does not fulfill all requirements - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #98094

closed

Abort commit if commit message does not fulfill all requirements

Added by Simon Schaufelberger over 2 years ago. Updated about 2 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Target version:

next-patchlevel

Start date:

2022-08-06

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Currently there is only an output message but the commit still goes through.

Actions

Copy link

Updated by Simon Schaufelberger over 2 years ago

Subject changed from Abort commit if commit message does not fulfull all requirements to Abort commit if commit message does not fulfill all requirements

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75386

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75359

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75360

Actions

Copy link

Updated by Anonymous over 2 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset da2a1b8b8e4d368739a42d37c704e76a1af2506c.

Actions

Copy link

Updated by Anja Leichsenring over 2 years ago

this turned out to be a bad idea, loosing a well written commit message is way worse than missing any formalities that will be detected during code review anyway (usually, if not the world will still exist).

The patch gets reverted in all branches.

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from Resolved to Under Review

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75452

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75454

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75453

Actions

Copy link

#10