TYPO3 Core

I'm pretty sure there are still a bunch of "undefined array key" warnings hidden in the TYPO3 core when used in combination with PHP 8.

To identify and address those issues, I created a PsalmPHP plugin tweaking some static code analysis topics (e.g. static/self references, or ignoring $GLOBALS) for creating a list with potential code locations that could be enhanced. This list is quite long and some aspects might feel okayish... Anyway, I'm just posting the results as TXT and SARIF file.

Processing¶

# process with max. 1 thread
bin/psalm --memory-limit=8G --threads=1 --no-cache \
    --report=results.sarif --output-format=github

# Visual Studio Code SARIF needs special JSON and absolute paths
(@sed@ on macOS neeeds `-i ''`, on Linux just `-i`)
sed -i '' \
    -e 's,\\/,/,g' \
    -e's,{"uri":"typo3/,{"uri":"'"$(pwd)"'/typo3/,g' results.sarif

Tools¶

• https://psalm.dev/
• https://marketplace.visualstudio.com/items?itemName=WDGIS.MicrosoftSarifViewer

Subtasks¶

The subtasks of this issue are basically all system extensions, that have been approached systematically. Arbitrary one-liners can be referenced, but not added as subtasks.