Actions
Feature #99585
openAdd Upgrade Wizard for Apache htaccess files
Status:
Accepted
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
Start date:
2023-01-17
Due date:
% Done:
0%
Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:
On Location Sprint
Description
- (for instance)
- check state of
fileadmin/.htaccess
and compare with current version provided in TYPO3 - offer diff view and/or possibility to override or deny (for CLI)
Files
Updated by Christian Kuhn over 1 year ago
- Status changed from New to Needs Feedback
The "Directory Status" module in the install tool was / is designed to deal with stuff like this.
Updated by Oliver Hader over 1 year ago
That's how it the install tool current "deals with it" in TYPO3 v12...
Updated by Benni Mack over 1 year ago
- Target version changed from 12.3 to 12 LTS
Updated by Benni Mack over 1 year ago
- Target version changed from 12 LTS to Candidate for Major Version
Updated by Oliver Hader over 1 year ago
- Assignee deleted (
Oliver Hader)
Would be a nice enhancement, but I don't have time for working on this...
Updated by Oliver Hader over 1 year ago
- Status changed from Needs Feedback to Accepted
Updated by Stephan Jorek about 1 year ago
Hey folks,
after discussing a little bit with some core-devs (during the T3DD2023 coding-night), a wanted to sum up what we've analysed so far.
- Mark (.htaccess) file candidates that could be handled by this feature in
TYPO3\CMS\Install\FolderStructure\DefaultFactory::getDefaultStructureDefinition()
- Update the implementation used in
TYPO3\CMS\Install\Controller\EnvironmentController::folderStructureGetStatusAction()
to show a green badge, if the marked files from (1.) are either unchanged or only contain (line-based) additions (but no changes).- This ensures that custom rules don't lead to false positives (ie. where rules have been added to
public/.htaccess
) - This should be implemented in
TYPO3\CMS\Install\FolderStructure\FileNode
, probably utilisingsebastian/diff
- This ensures that custom rules don't lead to false positives (ie. where rules have been added to
- Update
TYPO3\CMS\Install\FolderStructure\FileNode::fixSelf()
adding a additional section which deals with changed files, propably by creating backup files and restoring the desired file contents - Implement unit-tests to ensure the above changes are working
- Implement an update-wizard which utilises
TYPO3\CMS\Install\FolderStructure\DefaultFactory
to reset the changed files as described above. Of course after the user has given confirmation, probably after presenting a unified diff to the user first. - Take care about the following implementations, which are using
TYPO3\CMS\Install\FolderStructure\DefaultFactory
TYPO3\CMS\Install\Command\SetupCommand
TYPO3\CMS\Install\Controller\InstallerController
TYPO3\CMS\Install\Service\CoreUpdateService
Actions