Project

General

Profile

Actions

Bug #99744

closed

Take care of migrating AdditionalConfiguration

Added by Josef Glatz almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
System/Bootstrap/Configuration
Target version:
-
Start date:
2023-01-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Problem/Description

There are situations where an AdditionalConfiguration.php needs to be migrated too, even if a settings.php is in place:

One problematic scenario is DDEV: It's actually not really straight forward for newcomers or contributors to work on the core due to the AdditionalConfiguration.php generation. Since there are big changes in core's file structure, DDEV will wait for any modifications in the TYPO3 integration part until TYPO3 v12 lts is released. This was recently (jan 2023) discussed between @Benni Mack and @Simon Gilli.

Instead of adding infos in the documentation of the TYPO3 contribution guide, I walked through the code and believe that this fix should be right in the core.

ToDo(s)

  • Add a check if AdditionalConfiguration.php needs migrated even if settings.php is already in place
  • Add a "silent" migration like it is already in place for the "LocalConfiguration.php"

Acceptance Criteria

  • main-installation with DDEV migrates typo3conf/AdditionalConfiguration.php even if the recently introduced settings.php is already in place.

Scenarios for Testing

$properlyConfigured = TRUE
```
new:
    settings.php
legacy:
    -
```

$properlyConfigured = TRUE
```
new:
    settings.php
    additional.php
legacy:
    -
```

$properlyConfigured = FALSE
```
    new:
        settings.php
    legacy:
        AdditionalConfiguration.php
```

$properlyConfigured = TRUE
```
    new:
        settings.php
        additional.php
    legacy:
        AdditionalConfiguration.php
```

$properlyConfigured = FALSE
```
    new:

    legacy:
        LocalConfiguration.php
        AdditionalConfiguration.php
```

$properlyConfigured = FALSE
```
    new:

    legacy:
        LocalConfiguration.php
```


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #100013: Ensure minimal I/O for configuration migration checks during BootstrapClosedMarkus Klein2023-02-22

Actions
Related to TYPO3 Core - Task #105546: Extend migration lifetime of legacy configuration migrationResolvedOliver Bartsch2024-11-05

Actions
Actions #1

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #2

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #3

Updated by Josef Glatz almost 2 years ago

  • Description updated (diff)
Actions #4

Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #5

Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #6

Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #7

Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #8

Updated by Gerrit Code Review almost 2 years ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #9

Updated by Gerrit Code Review almost 2 years ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #10

Updated by Gerrit Code Review almost 2 years ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #11

Updated by Gerrit Code Review almost 2 years ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #12

Updated by Josef Glatz almost 2 years ago

  • Description updated (diff)
Actions #13

Updated by Gerrit Code Review almost 2 years ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #14

Updated by Gerrit Code Review almost 2 years ago

Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #15

Updated by Gerrit Code Review almost 2 years ago

Patch set 13 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #16

Updated by Gerrit Code Review almost 2 years ago

Patch set 14 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #17

Updated by Gerrit Code Review almost 2 years ago

Patch set 15 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634

Actions #18

Updated by Anonymous over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #19

Updated by Markus Klein over 1 year ago

  • Related to Task #100013: Ensure minimal I/O for configuration migration checks during Bootstrap added
Actions #20

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions #21

Updated by Oliver Bartsch 16 days ago

  • Related to Task #105546: Extend migration lifetime of legacy configuration migration added
Actions

Also available in: Atom PDF