Bug #99796
closedClickEnlargeViewHelper: wrong data-type for argument `configuration`
100%
Description
ClickEnlargeViewHelper initializes its argument `configuration` as 'mixed', containing "String, \TYPO3\CMS\Core\Resource\File or \TYPO3\CMS\Core\Resource\FileReference with link configuration".
In fact, this argument is used only once: when passing it to `TypoScriptService::convertPlainArrayToTypoScriptArray()`. This method expects its argument to be an array (`@param array $typoScriptArray The TypoScript array (e.g. array('foo' => 'TEXT', 'foo.' => array('bar' => 'baz')))`) and has 'array' as its type declaration.
Seems, there are two issues:- The documentation of the argument does not meet its real use
- The data-type does not meet the usage and will throw an exception
Updated by Georg Ringer almost 2 years ago
- Status changed from New to Accepted
you are absolutley correct, the documentation is wrong. as mixed however allows array as well, nothing will break.
do you wanna push a change?
Updated by Gerrit Code Review almost 2 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77678
Updated by Gerrit Code Review almost 2 years ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77850
Updated by Gerrit Code Review almost 2 years ago
Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77850
Updated by Georg Ringer almost 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9b67512c93962cf3986b40fef00d03a4d92cb665.