Project

General

Profile

Actions

Bug #99796

closed

ClickEnlargeViewHelper: wrong data-type for argument `configuration`

Added by Julian Hofmann almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2023-02-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

ClickEnlargeViewHelper initializes its argument `configuration` as 'mixed', containing "String, \TYPO3\CMS\Core\Resource\File or \TYPO3\CMS\Core\Resource\FileReference with link configuration".

In fact, this argument is used only once: when passing it to `TypoScriptService::convertPlainArrayToTypoScriptArray()`. This method expects its argument to be an array (`@param array $typoScriptArray The TypoScript array (e.g. array('foo' => 'TEXT', 'foo.' => array('bar' => 'baz')))`) and has 'array' as its type declaration.

Seems, there are two issues:
  • The documentation of the argument does not meet its real use
  • The data-type does not meet the usage and will throw an exception
Actions #1

Updated by Georg Ringer almost 2 years ago

  • Status changed from New to Accepted

you are absolutley correct, the documentation is wrong. as mixed however allows array as well, nothing will break.

do you wanna push a change?

Actions #2

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77678

Actions #3

Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77850

Actions #4

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77850

Actions #5

Updated by Georg Ringer almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF