Bug #99797
closedRedirects don't respect current language
100%
Description
My installation has multiple domains with different language:
my-domain.se (default)
my-domain.dk
The redirects only go to the default language.
Here are the redirect scenarios that don't work as expected:
1)
Source domain: my-domain.dk
Source path: /source-path-dk
Source target: t3://page?uid=1405
When visiting: my-domain.dk/source-path-dk
Expected redirect: my-domain.dk/dk-page
Actual redirect: my-domain.se/se-page
2)
Source domain: *
Source path: /source-path
Source target: t3://page?uid=1405
When visiting: my-domain.dk/source-path
Expected redirect: my-domain.dk/dk-page
Actual redirect: my-domain.se/se-page
The same happens when linking to records using RecordLinkHandler.
The problem seems to be in bootFrontendController in RedirectService where it instantiates TSFE where it passes the $site->getDefaultLanguage() to the "siteLanguage" parameter.
I checked the middleware TypoScriptFrontendInitialization how it creates the TypoScriptFrontendController.
It passes $request->getAttribute('language', $site->getDefaultLanguage()) to the "siteLanguage" and when I did the same change the scenarios above work as expected.
Files
Updated by Gerrit Code Review about 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77677
Updated by Stefan Bürk about 2 years ago
- Assignee set to Stefan Bürk
will have a look in the next round.
Updated by Peter Kraume about 1 year ago
I just tested the patch with TYPO v11.5 and it works perfectly for me for pages and also records (t3://record?identifier=foobar&uid=5).
Updated by Peter Kraume about 1 year ago
- Related to Bug #99839: Can't append L in additionalParams when using recordLink to redirect added
Updated by Peter Kraume about 1 year ago
- Related to Bug #101156: Record links with L>0 records resolve to page URLs with L=0, also record links ignore the L parameter completly added
Updated by Georg Ringer 7 months ago
- Related to Task #102868: Avoid TSFE getSite(), getLanguage(), pageArguments added
Updated by Georg Ringer 7 months ago
- Status changed from Under Review to Closed
this has been fixed with #102868 in 12+
Updated by André Buchmann about 2 months ago
@Georg Ringer we used the abandoned patch in TYPO3 11.5 successfully for our redirects.
After the upgrade to 12.4.24 we removed the patch and tried it again. The issue is not fixed for us.
It only works when I apply the same patch again here: https://github.com/typo3/typo3/blob/3dcf63dcbbfdd108aa4ce2207b27fc80b7eb8995/typo3/sysext/redirects/Classes/Service/RedirectService.php#L410-L410
Updated by Stefan Bürk 16 days ago
- Related to Task #105987: Add additional `EXT:redirects` functional tests added
Updated by Stefan Bürk 16 days ago
· Edited
- TYPO3 Version changed from 11 to 12
Adding some tests to cover this case (show it has been fixed in main, but not in v12)
with #105987 as preparation.
Updated by Gerrit Code Review 12 days ago
- Status changed from New to Under Review
Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77677
Updated by Georg Ringer 12 days ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 69ff59ef8b13c6e401b2900e2e370036cbcdd850.