Project

General

Profile

Actions

Bug #100856

closed

SilentConfigurationUpgradeService removed FE/versionNumberInFilename setting

Added by Alexander Stehlik over 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Install Tool
Target version:
Start date:
2023-05-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.2
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

There seems to be an error in the logic of \TYPO3\CMS\Install\Service\SilentConfigurationUpgradeService::migrateVersionNumberInFileNameSetting():

The option is always removed, when the value is not embed:

if ($currentOption === 'embed') {
    $confManager->setLocalConfigurationValueByPath('FE/versionNumberInFilename', true);
} else {
    $confManager->removeLocalConfigurationKeysByPath(['FE/versionNumberInFilename']);
}

This does not seem to make sense because the value is also removed, when it is set to true.

Am I missing something here or this be a conditional else, something like:

if ($currentOption === 'embed') {
...
} elseif (!$currentOption) {
    $confManager->removeLocalConfigurationKeysByPath(['FE/versionNumberInFilename']);
}

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #99810: Streamline "createVersionNumberedFilename"ClosedBenni Mack2023-02-03

Actions
Actions

Also available in: Atom PDF