Project

General

Profile

Actions

Bug #100865

closed

Automatic TYPO3 core update not working due to button's data attribute

Added by Daniel Widmer over 1 year ago. Updated 4 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Start date:
2023-05-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In my installation of TYPO3 12.4.1 on a UNIX server with PHP 8.2 (legacy installation, not via Composer), the automatic update of the core does not work. The "Update TYPO3 core" modal of the Upgrade modul in the backend opens, but a click on the button "Check for core updates" shows no reaction. The browser's JavaScript console reports: Uncaught Unknown update action "undefined". Source: core-update.js line 13, character 2040. I find in that JavaScript file that the mentioned error message is shown if the modal's button is clicked but it has no "data-action" attribute. And in fact, in the source code of webpage, the <button> tag does not have a "data-action" attribute. This is in difference to TYPO3 11.5.27 where the "data-action" attribute exists.
I then found that the attribute is indeed defined: in typo3/sysext/install/Classes/Controller/UpgradeController.php line 279 set a buttons's dataAttribute to 'action' => 'checkForUpdate'. But according to breaking change #98288, the button property "dataAttributes" has been removed without replacement. For this reason, the "data-action" attribute is not present in the <button> tag and the checking for a new TYPO3 version does not work.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #98288: Migrate backend modal component to litClosedBenjamin Franzke2022-09-07

Actions
Related to TYPO3 Core - Bug #101473: Update TYPO3 Core > Error JqueryClosed2023-07-28

Actions
Actions #1

Updated by Oliver Hader over 1 year ago

  • Related to Task #98288: Migrate backend modal component to lit added
Actions #2

Updated by Oliver Hader over 1 year ago

  • Status changed from New to Accepted

Confirmed in TYPO3 v12.4.1

Actions #3

Updated by Benni Mack over 1 year ago

  • Target version changed from 12 LTS to Candidate for patchlevel
Actions #4

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79802

Actions #5

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79803

Actions #6

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79803

Actions #7

Updated by Benjamin Franzke over 1 year ago

  • Related to Bug #101473: Update TYPO3 Core > Error Jquery added
Actions #8

Updated by Anonymous over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack 4 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF