Project

General

Profile

Actions

Bug #102760

closed

ext_conf_template.txt is parsed inconsistently, leading to missing configuration fields

Added by Christian Spoo 11 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Category:
Extension Manager
Target version:
-
Start date:
2024-01-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If I have an extension with the following ext_conf_template.txt:

# cat=foo//0; type=boolean; label=some config
bar = 0

# cat=foo//1; type=boolean; label=other config
baz = 0

only the second configuration option is shown in the Backend. However, if I replace the double slashes with single ones, like so:
# cat=foo/0; type=boolean; label=some config
bar = 0

# cat=foo/1; type=boolean; label=other config
baz = 0

both options are shown. As the documentation defines ext_conf_template.txt's syntax to be similar to the one used for the TS constants editor, I think this is a bug. The examples above are comparable to those in the documentation (https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/UsingSetting/TheConstantEditor.html#id3).


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #97816: New TypoScript parserClosed2022-06-27

Actions
Actions #1

Updated by Christian Kuhn 11 months ago

Actions #2

Updated by Georg Ringer 5 months ago ยท Edited

still buggy in 12

with


# cat=Backend; type=string; label=LLL:EXT:backend/Resources/Private/Language/locallang.xlf:config.backendFavicon
backendFavicon =

# cat=foo//0; type=boolean; label=some config
bar = 0

# cat=foo//1; type=boolean; label=other config
baz = 0

all 3 settings are shown.
if 1st one is removed, only setting baz is shown

Actions #3

Updated by Georg Ringer 5 months ago

  • Status changed from New to Accepted
  • Assignee set to Christian Kuhn
Actions #4

Updated by Gerrit Code Review 5 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84912

Actions #5

Updated by Garvin Hicking 5 months ago

This also happened in v13/main.

Note that the problem is not really caused by using double slash notation or having another element come before, but the "//0" leading to a falsy evaluation.

A single slash would just hide this problem because then automatic indexing would take place. As well as placing any other element before it, which would also affect the ordering.

Please check out the patch to see if that helps.

Actions #6

Updated by Gerrit Code Review 5 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84912

Actions #7

Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84912

Actions #8

Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85027

Actions #9

Updated by Garvin Hicking 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF