TYPO3 Core

Just from my current project:

## There is a bug, that it doesn't work on level
##    TCEFORM.[tableName].[fieldName].types.[typeName].itemsProcFunc
## therefore this level is used:
##    TCEFORM.[tableName].[fieldName].itemsProcFunc

Actually it's quite easy to apply it with

TCEFORM.tt_content.layout.itemsProcFunc < TCEFORM.tt_content.layout.types
TCEFORM.tt_content.layout.types >

Garvin Hicking wrote in #note-3:

Could you maybe give an example of what kind of itemsProcFunc you utilize and how/where you're processing the items and what is the expected result?

First guess would be that the 'site' is a bit more leaning towards frontend instantiation rather than backend, so it might very well be either a regression or conceptual choice, and I'm trying to get the picture :)

Hi Garvin,

I linked the GitHub issue in the description, this happened in my extension where I can select a site in a record, see here.

Hi Daniel,

Ah sorry, I missed that one then. Probably the latest version is here with https://review.typo3.org/c/Packages/TYPO3.CMS/+/77033 that might have broken it.

That patch uses "realPid" ($params['effectivePid'], containing $realPid from getProcessingItems - and you previously used "site".

Could you maybe show a var-dump/print_r/debugUtility output maybe of what your itemsProcFunc gets passed as $params?

It feels to me like the current 'site' addition is very much tailored for "tt_content" use, resolving a page uid - and in your case of course, TCA items of another database row have something else probably stored for the records, they maybe live in a sysfolder?

However I would wonder why 'site' disappeared from your 'row' info, as it should clearly be part of the full array. Maybe because "site" is somehow treated special?! Are all other columns contained in your 'row' info? If you renamed it to something like "siteUid", would that be transported?

It could be that https://github.com/TYPO3/typo3/commit/63e3a400bce6c93b135444161f5b5066c3e8a34a affected what is passed to $params['row'], and that could be a bug.

Needs further inspection, but need to stop for now.

@Daniel Dorndorf Thanks for getting back.

I was now able to locate the actual breaking change:

https://github.com/TYPO3/typo3/commit/7a238b3b3c56a0436e1a2805cc511ebf52452f30

This seems to be a performance optimization, preventing to get the whole row.

BackendUtility::getRecordTitle() actually receives the whole $row, but the call to this:

$recordTitle = self::getProcessedValue(
                    $table,
                    $ctrlLabel,
                    (string)$ctrlLabelValue,
                    0,
                    false,
                    false,
                    $row['uid'] ?? null,
                    $forceResult
                ) ?? '';

has no parameter to actually pass the row on to BU::getProcessedValue()

I now created a patch that would do that passing now. It applies to main, but the patch also properly seems to apply to v12 as well.

Would you be able/willing to see if the patch works out for you (in my case, it makes the whole parameters available again).

Hi @Garvin Hicking,

Where can I find the patch?

I testet this by reversing the changes of the commit you send me: https://github.com/TYPO3/typo3/commit/7a238b3b3c56a0436e1a2805cc511ebf52452f30
Then it worked properly again, the site identifier in the field and the sys_language_uid is available again.

Greetings
Daniel

@Daniel Dorndorf Here, linked in the issue: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85802

Garvin Hicking wrote in #note-10:

@Daniel Dorndorf Here, linked in the issue: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85802

@Garvin Hicking ah sry I didn't see before.
I also testet this and it worked properly again.

Great! Maybe you can drop a vote in gerrit? ;)

Oli Bartsch will be on vacation, but we'll need to add a regression unit/functional test to ensure this doesn't break and I'll need his feedback. So it might take a bit until it gets merged.

Done, I currently have a workaround implemented fetching the row manually, not optimal but will work for the time.
If this gets released I'll reverse it and increase the minimum required version and so on.

Thanks for your patch.

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85802

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85802

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85802

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85802

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85802

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85802

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86217

Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86217