Project

General

Profile

Actions

Task #103499

open

ckeditor 5 - Add parameter explanation/description

Added by wini2 no-lastname-given 4 months ago. Updated 1 day ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2024-03-28
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.2
Tags:
ckeditor5
Complexity:
Sprint Focus:

Description

ckeditor5 presets contain configurations like (Full.yaml)
- { name: 'Yellow marker', element: 'span', classes: [], styles: { background-color: 'yellow' } }
but styles does nothing at all. A yellow marker appears in the dropdown only if a class is defined, so the conculsion seems that styles is superfluous (maybe a leftover form ckeditor4). If I'm wrong, please add an explanation in the docs.

Actions #1

Updated by Chris Müller 4 months ago

  • Category set to RTE (rtehtmlarea + ckeditor)
Actions #2

Updated by Gerrit Code Review 1 day ago

  • Status changed from New to Under Review

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84679

Actions #3

Updated by Garvin Hicking 1 day ago

The configuration in this part is not specific to TYPO3, so CKEditor5 dictates this:

https://ckeditor.com/docs/ckeditor5/latest/api/module_style_styleconfig-StyleDefinition.html

Sadly I haven't found a migration guide for this in the CKEditor (https://ckeditor.com/docs/ckeditor5/latest/updating/migration-from-cke4.html).

However, the TYPO3 Changelog contains a note about it:

https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Feature-96874-CKEditor5.html#configuration-options

In this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84679 I'm now also removing this invalid "styles:" syntax from the definition. Sadly this kind of makes a "yellow marker" invalid, because it's only controlled via the CSS class, and one has to implement such a CSS class in their own frontend and CKEditor CSS definitions...

Actions

Also available in: Atom PDF