Task #103499: ckeditor 5 - Add parameter explanation/description - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (1)

Garvin Hicking

Actions

Copy link

Task #103499

closed

ckeditor 5 - Add parameter explanation/description

Added by wini2 no-lastname-given 8 months ago. Updated about 1 month ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

RTE (rtehtmlarea + ckeditor)

Target version:

Start date:

2024-03-28

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

8.2

Tags:

ckeditor5

Complexity:

Sprint Focus:

Description

ckeditor5 presets contain configurations like (Full.yaml)
- { name: 'Yellow marker', element: 'span', classes: [], styles: { background-color: 'yellow' } }
but styles does nothing at all. A yellow marker appears in the dropdown only if a class is defined, so the conculsion seems that styles is superfluous (maybe a leftover form ckeditor4). If I'm wrong, please add an explanation in the docs.

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Chris Müller 8 months ago

Category set to RTE (rtehtmlarea + ckeditor)

Actions

Copy link

Updated by Gerrit Code Review 4 months ago

Status changed from New to Under Review

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84679

Actions

Copy link

Updated by Garvin Hicking 4 months ago

The configuration in this part is not specific to TYPO3, so CKEditor5 dictates this:

https://ckeditor.com/docs/ckeditor5/latest/api/module_style_styleconfig-StyleDefinition.html

Sadly I haven't found a migration guide for this in the CKEditor (https://ckeditor.com/docs/ckeditor5/latest/updating/migration-from-cke4.html).

However, the TYPO3 Changelog contains a note about it:

https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Feature-96874-CKEditor5.html#configuration-options

In this patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84679 I'm now also removing this invalid "styles:" syntax from the definition. Sadly this kind of makes a "yellow marker" invalid, because it's only controlled via the CSS class, and one has to implement such a CSS class in their own frontend and CKEditor CSS definitions...

Actions

Copy link

Updated by Gerrit Code Review 4 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84679

Actions

Copy link

Updated by Gerrit Code Review 4 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84679

Actions

Copy link

Updated by Gerrit Code Review 3 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84679

Actions

Copy link

Updated by Gerrit Code Review 3 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84679

Actions

Copy link

Updated by Gerrit Code Review 3 months ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84679

Actions

Copy link

Updated by Gerrit Code Review 3 months ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/84679

Actions

Copy link

#10

Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/85766

Actions

Copy link

#11