Project

General

Profile

Actions
Copy link

Bug #105046

closed

Outdated v13 Breaking documentation for TypoScriptFrontendController

Added by Mario Lubenka 2 months ago. Updated 30 days ago.

Status:
Closed
Priority:
Should have
Assignee:
Christian Kuhn
Category:
Documentation
Target version:
13 LTS
Start date:
2024-09-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:
Stabilization Sprint

Description

I just stumbled across this:

https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.html#breaking-102621-most-tsfe-members-marked-internal-or-read-only

According to v13 changelog the method TypoScriptFrontendController->getPageArguments() was marked as internal. However it was actually removed later:
https://github.com/TYPO3/typo3/commit/e32c78585912fa362a8d9a69459a7f0892e5bf89#diff-6dd96118370dfe9aba2916b16f7c479d482af2fae7a4fe20a37553b03cf8d997L1645

I think PageArguments can now be retrieved from the request object on $request?->getAttribute('routing').
However developers need to check if the return value is actually a PageArguments instance, as the attribute can return different objects (not sure if that is planned to change until the final release).

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Task #105230: Declare TypoScriptFrontendController deprecatedClosed2024-10-08

Actions
Actions
Copy link
 #1

Updated by Christian Kuhn 2 months ago

I'm planning for another .rst file regarding TSFE during 13.4 stabilization phase within next weeks.

Actions
Copy link
 #2

Updated by Benni Mack about 2 months ago

  • Status changed from New to Accepted
Actions
Copy link
 #3

Updated by Garvin Hicking about 1 month ago

  • Assignee set to Christian Kuhn

(Hope its ok to set the assignment, lolli)

Actions
Copy link
 #4

Updated by Christian Kuhn about 1 month ago

  • Related to Task #105230: Declare TypoScriptFrontendController deprecated added
Actions
Copy link
 #5

Updated by Gerrit Code Review about 1 month ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86493

Actions
Copy link
 #6

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86493

Actions
Copy link
 #7

Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86493

Actions
Copy link
 #8

Updated by Christian Kuhn about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #10

Updated by Franz Holzinger 30 days ago

Here is a tested example:

Before:

if ($GLOBALS['TSFE']->type) {
        $addQueryString['type'] = $GLOBALS['TSFE']->type;
    }

After:

$pageType = $request->getAttribute('routing')->getPageType();
    if ($pageType) {
        $addQueryString['type'] = $pageType;
    }

Notice:
No method getPageArguments has been called any more.

Actions
Copy link

Also available in: Atom PDF