Bug #105046
closedOutdated v13 Breaking documentation for TypoScriptFrontendController
100%
Description
I just stumbled across this:
According to v13 changelog the method TypoScriptFrontendController->getPageArguments()
was marked as internal. However it was actually removed later:
https://github.com/TYPO3/typo3/commit/e32c78585912fa362a8d9a69459a7f0892e5bf89#diff-6dd96118370dfe9aba2916b16f7c479d482af2fae7a4fe20a37553b03cf8d997L1645
I think PageArguments can now be retrieved from the request object on $request?->getAttribute('routing')
.
However developers need to check if the return value is actually a PageArguments
instance, as the attribute can return different objects (not sure if that is planned to change until the final release).
Updated by Christian Kuhn about 1 month ago
I'm planning for another .rst file regarding TSFE during 13.4 stabilization phase within next weeks.
Updated by Garvin Hicking 24 days ago
- Assignee set to Christian Kuhn
(Hope its ok to set the assignment, lolli)
Updated by Christian Kuhn 23 days ago
- Related to Task #105230: Declare TypoScriptFrontendController deprecated added
Updated by Gerrit Code Review 23 days ago
- Status changed from Accepted to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86493
Updated by Gerrit Code Review 23 days ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86493
Updated by Gerrit Code Review 23 days ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/86493
Updated by Christian Kuhn 23 days ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f1c0767f560ff7c08dfc127888f89583f2617d67.
Updated by Franz Holzinger 9 days ago
Here is a tested example:
Before:
if ($GLOBALS['TSFE']->type) {
$addQueryString['type'] = $GLOBALS['TSFE']->type;
}
After:
$pageType = $request->getAttribute('routing')->getPageType();
if ($pageType) {
$addQueryString['type'] = $pageType;
}
Notice:
No method getPageArguments
has been called any more.