Project

General

Profile

Actions

Bug #10831

closed

New preview window shows wrong behavior for new page in LIVE WS

Added by Francois Suter about 14 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Category:
Workspaces
Target version:
-
Start date:
2010-11-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Having tested RFC #13610 pending in the core list, I was able to play with the new workspace preview. I found the following problem: assume that you have created a new page and are previewing it. The LIVE tab/frame used to show an (error) message in the previous versions of TYPO3:

"New page! The previewed page is created in the workspace and has no counterpart in the live workspace."

This does not happen anymore. Instead we get a TYPO3 error about a broken rootline (which is correct in principle, but far less informative than the message that appeared before). This feature should not be lost.


Files

10831.patch (4.59 KB) 10831.patch Tolleiv Nietsch, 2010-11-24 18:25
10831v2.patch (4.98 KB) 10831v2.patch Tolleiv Nietsch, 2010-11-29 18:10
Actions #1

Updated by Tolleiv Nietsch about 14 years ago

  • Status changed from New to Accepted

Absolutely right thanks for bringing that up

Actions #2

Updated by Steffen Ritter about 14 years ago

  • Target version set to 4.5 Beta 2
Actions #3

Updated by Tolleiv Nietsch almost 14 years ago

  • Assignee set to Tolleiv Nietsch
Actions #5

Updated by Tolleiv Nietsch almost 14 years ago

  • % Done changed from 0 to 90

pending as FYI48 in the typo3.team.workspaces newsgroup

Actions #6

Updated by Tolleiv Nietsch almost 14 years ago

  • Status changed from Accepted to Under Review
Actions #7

Updated by Tolleiv Nietsch almost 14 years ago

Committed to trunk (rev. 3105)

Actions #8

Updated by Francois Suter almost 14 years ago

I'm sorry but that doesn't work, because you forgot to pass the $language parameter in the call tx_Workspaces_Service_Workspaces::isNewPage() (in the PreviewController.php, line 95).

BTW, there's a typo in the same file, the line just above: "supposed" => "supported"

Actions #9

Updated by Michael Stucki almost 11 years ago

  • Category set to Workspaces
Actions #10

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
  • Target version deleted (4.5 Beta 2)
Actions #11

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF