Project

General

Profile

Actions

Bug #14183

closed

FIX: indexed search external links

Added by old_bartv over 20 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Indexed Search
Target version:
-
Start date:
2004-05-26
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When indexed search shows external links (like indexed PDF documents), it does not add the target that is specified in "result_link_target" to the result links.

Here's a fix: in typo3/ext/indexed_search/pi/class.tx_indexedsearch.php :: printResultRow(), replace

if ($row["show_resume"]) { // Can link directly.
$title = '<a href="'.$row["data_filename"].'">'.$row["result_number"].": ".$this->makeTitle($row
).'</a>';
}

with

if ($row["show_resume"])        {       // Can link directly.
// Target set?
$target = $this->conf["result_link_target"]?'target="'.$this->conf["result_link_target"].'"':'';
$title = '&lt;a href=&quot;&#039;.$row[&quot;data_filename&quot;].&#039;&quot; &#039; . $target . &#039;&gt;'.$row["result_number"].": ".$this->makeTitle($row).'&lt;/a&gt;';
}
(issue imported from #M120)

Files

10392.diff (1.79 KB) 10392.diff Administrator Admin, 2010-03-17 13:55

Related issues 1 (0 open1 closed)

Is duplicate of TYPO3 Core - Bug #19990: Indexed search does not use config.fileTarget for filesClosedDmitry Dulepov2009-02-09

Actions
Actions #1

Updated by old_bartv over 20 years ago

Oops, Mantis ate my text! Anyway, insert $target in the string that's stored in $title and you're all set.

Actions #2

Updated by David Bruchmann over 14 years ago

Due to the age of this bug I assume it can be closed.
Or can someone still reproduce this bug?

Actions #3

Updated by Xavier Perseguers over 14 years ago

Well, I had quickly a look at source code and at least the mentioned lines are still as for old_bartv. We should leave it open until it has been tested but it might as well be still buggy.

Many users do not use target anymore nowadays as it's not standard-compliant but still, this should work properly.

Actions #4

Updated by Dmitry Dulepov over 14 years ago

The patch is attached. Unfortunately I was not able to set "has patch" flag.

Actions #5

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF