Project

General

Profile

Actions

Bug #14246

closed

charset and generator meta tags are written in XHTML by default

Added by Sacha Vorbeck over 19 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Content Rendering
Target version:
-
Start date:
2004-07-21
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
3.7.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

On lines 597 and 599 of class.tslib_pagegen.php the generator and content-type meta-tags are written with a slash before the ending > of the tag.

This will make it impossible to generate valid HTML pages with TYPO3.

The slashes should either be made dependant on the selected doctype or just be removed as they get inserted anyway if you set config.xhtmlcleaning .

(issue imported from #M236)


Files

236.diff (3.32 KB) 236.diff Administrator Admin, 2010-04-30 15:44

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #22567: Some non-XHTML tags in BackendClosedSteffen Kamper2010-05-02

Actions
Has duplicate TYPO3 Core - Bug #15069: If doctype is not XHTML, closed metatags prevent w3c validationClosedSebastian Kurfuerst2005-10-17

Actions
Actions #1

Updated by Ingmar Schlecht over 19 years ago

Hmm, the long time goal still is XHTML, so I would not like to remove the slashes.

Perhaps we should create something like this:
config.htmlcleaning

However, isn't it better to just use "tidy"?
Does it still have these problems of destroying your layout?

cheers,
Ingmar

Actions #2

Updated by Sacha Vorbeck over 19 years ago

Hi Ingmar,

Hmm, the long time goal still is XHTML, so I would not like to remove the
slashes.

but then it is not possible to generate valid HTML-code with TYPO3. And that can`t be a desired behaviour, can it?

At the moment the default output of TYPO3 is HTML. If you want to have XHTML, you set the XHTML cleaning option and choose an appropriate doctype. The ending slashes will then be added automatically by the function processTag in class.tslib_pagegen.php.

Perhaps we should create something like this:
config.htmlcleaning

I don`t see the necessity of it as the standard output would be nice clean HTML without those two trailing slashes. They are a break of concept IMHO.

However, isn't it better to just use "tidy"?

I`m not sure about the effects tidy has on the general performance. Will the contents be piped through tidy and then be dumped into the TYPO3 cache?

Does it still have these problems of destroying your layout?

I guess tidy could solve this problem. But see above. I don`t understand why I have to use tidy if it`s only needed to remove those two slashes.

Ciao,
Sacha

Actions #3

Updated by Michael Scharkow about 19 years ago

I don't think tidy is a proper solution because a) it's costly in performance, b) it might not be available, c) page rendering should be correct with TYPO3 alone.
BTW, it's still hardcoded in 3.7

Actions #4

Updated by Sacha Vorbeck about 19 years ago

keyword:accessibility

Actions #5

Updated by Lars Houmark over 18 years ago

Is this to be fixed in the next version? It's very annoying. It's the only hardcoding done in all our installations :/

I agree that there should be added a variable, that would include the tag if xhtml_cleaning is enabled, but the default way should be without the trailing /.

Isn't it more than just 2 places. I think it's three or four, also the stylesheet inclusion is causing trouble though there is other ways of including the stylesheet ;)

Actions #6

Updated by Christian Buelter almost 14 years ago

attached patch is for current TYPO3 4.4 Trunk

Actions #7

Updated by Susanne Moog almost 14 years ago

rev 7484

Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF