TYPO3 Core

Any counterarguments against this fix?

edited on: 03.02.05 23:32

Hm, in 3.7 the hidden fields simply appear after the form tag. So it's up to the surrounding xhtml to supply a block-level tag.

keyword:accessibility

Error from w3's validator is (XHTML 1.1 strict!):

document type does not allow element "input" here; missing one of "ins", "del", "h1", "h2", "h3", "h4", "h5", "h6", "p", "div", "address", "fieldset" start-tag

In my case, the content area where this mailform is placed in is already inside a <div id="content"> so there is a surrounding block-level tag. But still, the input fields cannot "hang around" after the form tag. They must be enclosed inside a blockl-level tag, e.g. a <div>.

Improved patch adds display:none to the div.

One can probably see this in different ways, but requiring a block level element around a hidden field seems nonsense to me. Pffft.

Other than that, the patch looks good and should do no harm.

Fixed in 3.8 but only if the "accessibility" property is set.

While valid XHTML is currently mainyl an accessibility issue, this xhtml bug should be fixes regardless of the setting of the accessibility flag. So the bug must remain open until this depency is removed.

The div does no harm, so why the check?

OK, convinced me. I didn't realise that display:none was set!