TYPO3 Core

Can anybody confirm if this patch works, please?

Hi stucki,

The patch works. The only thing is that you have to download the "correct" version for unzip/gunzip. It took me half an hour to find the correct versions (from sf.net). The results of the zipfile is completed with some extra stuff like date, time, EA , ACL. The size part is missing but is printed in the unzip -l -qq command, but not printed on the screen (on purpose)?!?

Regards, Henk

hi henk!

as on unix, apart from the filename, there is no additional information printed, so this is the correct (i.e. identical) program behaviour.

necessary software: as on unix, you have to use the gnu win ports of these programs which may be downloaded from http://unxutils.sourceforge.net/ - you found that yourself.
i add this information to the "running typo3 on windows" wiki section.
hopefully, the changes are incorporated in 3.8.0-final

greets,

rainer

Confirmed: WORKING.

Congratulations.

Test environment:
- Windows XP.
- Typo3 WAMP installer (Typo3 QuickStart Setup).
- Typo3 QuickStart 3.7.0

Filetypes tested:
TAR, Z, GZ, ZIP

Note: Don't forget to add the required programs to the Typo3 on Windows Wiki page.

This patch is definitely wrong. The z parameter is removed on Unix, so it cannot unpack gzipped files. Please re-check.

no, it is corect. the gnu ports of tar doesn't understand the -z option (gunzip on the fly), so this behaviour is achieved by piping the compressed TAR through gunzip as i wrote in the patch comment:

[...]
// As of March 2005, there is no freely available, precompiled win32
// binary of tar that supports compressed tar archives (tgz/tar.gz/tar.z).
// Therefor, we pipe gunzip to stdout and let tar read from stdin.
// The archive itself remains compressed!
exec('gunzip c '.$this>file.' | tar t ',$t);
[...]

it even has the advantage that unlike on unix systems, the archive doesn't stay uncompressed on the server.

so this patch is working.

greets

rainer

@Rainer Sudhölter:

Yes, the archive is piped from gunzip to tar when running windows (the gnu tar for windows doesn't know "z"?! awkward!). But the tar call for other systems (Linux/Unix) misses the z argument, I think this is what was meant.

There is another thing that puzzles me: the x that is given to tar. Why isn't the archive checked with a simple "tar tvzf ..." call? "t" and "x" together looks like nonsense to me.

And you wrote:
"it even has the advantage that unlike on unix systems, the archive doesn't stay uncompressed on the server."
I don't understand that. When calling tar tvzf I never have anything left over.

@Karsten Dambekalns:
great, you found a typo:
the alternative for non-windows systems should read
"tar tzf ... " and not "tar txf ..."
perhaps that's why uncompressed archives were left over on my system.
i'll correct that and upload the patch again.
i also will inform the testers to re-check it.

big thanks for pointing this out!

rainer

Is this still valid in current versions?

Checking the source code: Yes, these lines are only executed on non-Windows.