Project

General

Profile

Actions

Bug #15771

closed

No range/lower like 2.000.000.000 in Flexforms

Added by Bernhard Kraft over 18 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Backend User Interface
Target version:
-
Start date:
2006-03-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The range: upper/lower evaluation in Flexforms is done with the same code as for normal tables. Normally an integer field would be of type integer in the table and thus the passed value to t3lib_tcemain.php method "checkValue_input" would be an integer.

But if flexforms are used the passed value is of type string and also the compare value from the DS is a string.

Now it is the case that the following script:
echo ('200000000'<'-200000000')?1:0;
?>

return 1 unexpectetly on 32-bit machines.

To prevent this from not working upper/lower bounds I added intval() calls to all four uses of $value and upper/lower.

See the attached patch:
flexform_range_patch_2006-03-06.diff

(issue imported from #M2776)


Files

flexform_range_patch_2006-03-06.diff (981 Bytes) flexform_range_patch_2006-03-06.diff Administrator Admin, 2006-03-06 18:25
Actions #1

Updated by Gerrit Code Review almost 13 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9022

Actions #2

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9022

Actions #3

Updated by Gerrit Code Review almost 12 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/9022

Actions #4

Updated by Gerrit Code Review almost 12 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/9022

Actions #5

Updated by Anja Leichsenring over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Gerrit Code Review over 11 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master_new has been pushed to the review server.
It is available at https://review.typo3.org/18678

Actions #7

Updated by Christian Kuhn over 11 years ago

  • Status changed from Under Review to Resolved
  • Target version deleted (0)
  • PHP Version deleted (4)
Actions #8

Updated by Gerrit Code Review over 11 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/19702

Actions #9

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/19753

Actions #10

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at https://review.typo3.org/19754

Actions #11

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19755

Actions #12

Updated by Georg Ringer over 11 years ago

  • Status changed from Under Review to Resolved
Actions #13

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF