Project

General

Profile

Actions

Feature #16613

closed

pass image alt and title attributes to showpic script

Added by Marc Bastian Heinrichs over 17 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2006-10-02
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

the patch includes modification on tslib_cObj->imageLinkWrap and SC_tslib_showpic to pass image attibutes to the showpic script:
- new TS property imageLinkWrap.alt for alt attribute
- stdWrap for alt and title property
- output for alt and title url-parameter

(issue imported from #M4316)


Files

4316.patch (2.84 KB) 4316.patch Administrator Admin, 2006-10-02 11:13
Actions #1

Updated by Marc Bastian Heinrichs over 17 years ago

- includes also the pass of metaCharset cause I don't want to instance an tslib_fe object (Opera needs the meta Content-Type tag to choose the correct charset / FF needs the Content-Type http header only)

Actions #2

Updated by Marc Bastian Heinrichs over 17 years ago

here is the TS for using this new feature:

tt_content.image.20.1.imageLinkWrap.title = TEXT
tt_content.image.20.1.imageLinkWrap.title {
field = titleText
split {
token.char = 10
token.if.isTrue = 1
returnKey.data = register : IMAGE_NUM_CURRENT
}
}

tt_content.image.20.1.imageLinkWrap.alt = TEXT
tt_content.image.20.1.imageLinkWrap.alt {
field = altText
ifEmpty.field = titleText
split {
token.char = 10
token.if.isTrue = 1
returnKey.data = register : IMAGE_NUM_CURRENT
}
}

Actions #3

Updated by Michael Stucki over 17 years ago

Just a small note so far: We cannot change the links for the popup windows because this would break compatibility with other extensions that use it.

Actions #4

Updated by Marc Bastian Heinrichs over 17 years ago

NAK, if extension uses imageLinkWrap.
ACK, if the extension build its own link to showpic .

We can support backwards compatibility by checking the hash also the old way.

It is not so long since the handling with showpic was changed completely and this is a nice addon for supporting accessibility.

Actions #5

Updated by Martin Kutschker about 17 years ago

What's the point of the alt attribute in this context? The title of the original link should have made it clear that a blind user gains nothing by clicking the link.

Anyway, I think we could use a modified patch. As setting the alt and the charset will not allows any DoS attack it can be omitted from the md5-hash.

And I think the shorter name "charset" is fine for passing on the charset. The distinction between metaCharset and renderCharset makes no sense in this context.

Actions #6

Updated by Alexander Opitz almost 11 years ago

  • Category deleted (Communication)
  • Status changed from New to Needs Feedback
  • Target version deleted (0)
  • PHP Version deleted (5)

The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?

Actions #7

Updated by Alexander Opitz over 10 years ago

  • Status changed from Needs Feedback to Closed

No feedback for over 90 days.

Actions #8

Updated by Marc Bastian Heinrichs over 10 years ago

Closing is okay for me :-)

Actions

Also available in: Atom PDF