Feature #16613
closed
pass image alt and title attributes to showpic script
Added by Marc Bastian Heinrichs about 18 years ago.
Updated about 11 years ago.
Description
the patch includes modification on tslib_cObj->imageLinkWrap and SC_tslib_showpic to pass image attibutes to the showpic script:
- new TS property imageLinkWrap.alt for alt attribute
- stdWrap for alt and title property
- output for alt and title url-parameter
(issue imported from #M4316)
Files
- includes also the pass of metaCharset cause I don't want to instance an tslib_fe object (Opera needs the meta Content-Type tag to choose the correct charset / FF needs the Content-Type http header only)
here is the TS for using this new feature:
tt_content.image.20.1.imageLinkWrap.title = TEXT
tt_content.image.20.1.imageLinkWrap.title {
field = titleText
split {
token.char = 10
token.if.isTrue = 1
returnKey.data = register : IMAGE_NUM_CURRENT
}
}
tt_content.image.20.1.imageLinkWrap.alt = TEXT
tt_content.image.20.1.imageLinkWrap.alt {
field = altText
ifEmpty.field = titleText
split {
token.char = 10
token.if.isTrue = 1
returnKey.data = register : IMAGE_NUM_CURRENT
}
}
Just a small note so far: We cannot change the links for the popup windows because this would break compatibility with other extensions that use it.
NAK, if extension uses imageLinkWrap.
ACK, if the extension build its own link to showpic .
We can support backwards compatibility by checking the hash also the old way.
It is not so long since the handling with showpic was changed completely and this is a nice addon for supporting accessibility.
What's the point of the alt attribute in this context? The title of the original link should have made it clear that a blind user gains nothing by clicking the link.
Anyway, I think we could use a modified patch. As setting the alt and the charset will not allows any DoS attack it can be omitted from the md5-hash.
And I think the shorter name "charset" is fine for passing on the charset. The distinction between metaCharset and renderCharset makes no sense in this context.
- Category deleted (
Communication)
- Status changed from New to Needs Feedback
- Target version deleted (
0)
- PHP Version deleted (
5)
The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?
- Status changed from Needs Feedback to Closed
No feedback for over 90 days.
Closing is okay for me :-)
Also available in: Atom
PDF