Bug #16965
closedLanguage HMENU getQueryArguments dont work
0%
Description
If property .getQueryArguments is added to language HMENU, the Language Menu will break.
At class.tslib_content.php, line 5524, function getQueryArguments() is written in such a way that $overruleQueryArgs will NOT be used UNLESS "exclude" property is set in its configuration.
Right now, I have to put .exclude = 1, as if boolean, so my menu works as expected.
A working fix may be changing line 5551:
if ($conf['exclude']) {
for:
if ($conf['exclude'] || $forceArgs) {
(issue imported from #M4955)
Files
Updated by Carlos A almost 18 years ago
The category was bad assigned (can it be edited?): it should have been "Frontend".
Updated by Oliver Hader almost 18 years ago
Was this behaviour introduced by TYPO3 4.1RC1 or could you reproduce this behaviour also in previous versions (4.1beta3 or 4.0.x)?
Updated by Bernhard Kraft about 17 years ago
This ws introduced during 4.0 development ....
http://typo3.svn.sourceforge.net/viewvc/typo3?view=rev&revision=1251
This commit contained the modification which created the problem with the language menu ... at least as I can see that ...
greets,
Bernhard
Updated by Bernhard Kraft about 17 years ago
I would suppose the following fix:
(Search for "*** CHANGE" to see my changes)
first we will have to change the line
// shortcut (no further processing necessary)
if (!$conf['exclude']) return '&'.t3lib_div::getIndpEnv('QUERY_STRING');
as this one would return directly if no 'exclude' is set ... so we also have to check for forceArgs here ...
next I moved the forceArgs block out of the 'exclude' if block - so that 'forceArgs' gets used even when no exclude is set ...
If you like I can create a diff ... but currently I do not have the time ...
i will create a diff and send a SVN patch request to the list tomorrow - but I would be interested in your opinions wheter you think my modifications are ok ...
greets,
Bernhard
Updated by Bernhard Kraft about 17 years ago
I attached a diff of the suggested changed ...
Updated by Alexander Opitz over 11 years ago
- Category deleted (
Communication) - Status changed from Accepted to Needs Feedback
- Target version deleted (
0)
The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?
Updated by Alexander Opitz about 11 years ago
- Status changed from Needs Feedback to Closed
- Assignee deleted (
Bernhard Kraft)
No feedback for over 90 days.