Bug #16965: Language HMENU getQueryArguments dont work - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #16965

closed

Language HMENU getQueryArguments dont work

Added by Carlos A about 17 years ago. Updated over 10 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

Start date:

2007-02-09

Due date:

% Done:

Estimated time:

TYPO3 Version:

4.1

PHP Version:

4.3

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

If property .getQueryArguments is added to language HMENU, the Language Menu will break.

At class.tslib_content.php, line 5524, function getQueryArguments() is written in such a way that $overruleQueryArgs will NOT be used UNLESS "exclude" property is set in its configuration.

Right now, I have to put .exclude = 1, as if boolean, so my menu works as expected.

A working fix may be changing line 5551:

if ($conf['exclude']) {

for:

if ($conf['exclude'] || $forceArgs) {
(issue imported from #M4955)

Files

patch_4955_getQueryArguments.diff (1.17 KB) patch_4955_getQueryArguments.diff

Administrator Admin, 2007-10-01 15:58

Actions

Copy link

Updated by Carlos A about 17 years ago

The category was bad assigned (can it be edited?): it should have been "Frontend".

Actions

Copy link

Updated by Oliver Hader about 17 years ago

Was this behaviour introduced by TYPO3 4.1RC1 or could you reproduce this behaviour also in previous versions (4.1beta3 or 4.0.x)?

Actions

Copy link

Updated by Bernhard Kraft over 16 years ago

This ws introduced during 4.0 development ....

http://typo3.svn.sourceforge.net/viewvc/typo3?view=rev&revision=1251

This commit contained the modification which created the problem with the language menu ... at least as I can see that ...

greets,
Bernhard

Actions

Copy link

Updated by Martin Kutschker over 16 years ago

Suggested fix looks ok to me.

Actions

Copy link

Updated by Bernhard Kraft over 16 years ago

I would suppose the following fix:

http://t3paste.org/CFgroV

(Search for "*** CHANGE" to see my changes)

first we will have to change the line
// shortcut (no further processing necessary)
if (!$conf['exclude']) return '&'.t3lib_div::getIndpEnv('QUERY_STRING');

as this one would return directly if no 'exclude' is set ... so we also have to check for forceArgs here ...

next I moved the forceArgs block out of the 'exclude' if block - so that 'forceArgs' gets used even when no exclude is set ...

If you like I can create a diff ... but currently I do not have the time ...
i will create a diff and send a SVN patch request to the list tomorrow - but I would be interested in your opinions wheter you think my modifications are ok ...

greets,
Bernhard

Actions

Copy link