Bug #16965
closed
Language HMENU getQueryArguments dont work
Added by Carlos A almost 18 years ago.
Updated about 11 years ago.
Description
If property .getQueryArguments is added to language HMENU, the Language Menu will break.
At class.tslib_content.php, line 5524, function getQueryArguments() is written in such a way that $overruleQueryArgs will NOT be used UNLESS "exclude" property is set in its configuration.
Right now, I have to put .exclude = 1, as if boolean, so my menu works as expected.
A working fix may be changing line 5551:
if ($conf['exclude']) {
for:
if ($conf['exclude'] || $forceArgs) {
(issue imported from #M4955)
Files
The category was bad assigned (can it be edited?): it should have been "Frontend".
Was this behaviour introduced by TYPO3 4.1RC1 or could you reproduce this behaviour also in previous versions (4.1beta3 or 4.0.x)?
Suggested fix looks ok to me.
I would suppose the following fix:
http://t3paste.org/CFgroV
(Search for "*** CHANGE" to see my changes)
first we will have to change the line
// shortcut (no further processing necessary)
if (!$conf['exclude']) return '&'.t3lib_div::getIndpEnv('QUERY_STRING');
as this one would return directly if no 'exclude' is set ... so we also have to check for forceArgs here ...
next I moved the forceArgs block out of the 'exclude' if block - so that 'forceArgs' gets used even when no exclude is set ...
If you like I can create a diff ... but currently I do not have the time ...
i will create a diff and send a SVN patch request to the list tomorrow - but I would be interested in your opinions wheter you think my modifications are ok ...
greets,
Bernhard
I attached a diff of the suggested changed ...
- Category deleted (
Communication)
- Status changed from Accepted to Needs Feedback
- Target version deleted (
0)
The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?
- Status changed from Needs Feedback to Closed
- Assignee deleted (
Bernhard Kraft)
No feedback for over 90 days.
Also available in: Atom
PDF