TYPO3 Core

one by one :-)
but thanks for your patch!

atm forgotten mail is not templatable, but markers could be added by TS using _LOCAL_LANG-setting

It is not possible to add markers to the TS template because of the way the translation string from the translation file is used:

<label index="ll_forgot_email_password">Uw wachtwoord
Hallo %s

Uw gebruikersnaam is "%s"
Uw wachtwoord is "%s"

Wij raden U aan uw wachtwoord direct te wijzigen in een wachtwoord dat U beter kunt onhouden.
</label>

The first line is used ad email subject . . . No newlines are possible in TS entry ( slash 'n' does not work).

Steffen notes:

You can use the LOCAL_LANG feature with 'braces' () . . . then you can enter a multi line translation string.

Also, you can use %$[n]s . . . . for example %$2s to use the second parameter.

plugin.tx_felogin_pi1 {
_LOCAL_LANG.nl {
ll_forgot_email_password (
Uw wachtwoord

Beste %2$s,

Uw gebruikersnaam is "%2$s"
Uw wachtwoord is "%3$s"

Wij raden U aan uw wachtwoord direct te wijzigen in een wachtwoord dat U beter kunt onhouden.
)
}
}

multiline is possible with syntax

bla.value (
...
...
...
)

It is also possible to use a specific replace string.
The %s values are email, username, password

If you want to use 2nd one(username) you can use syntax
%2$s

see http://www.php.net/manual/en/function.sprintf.php

Thorsten Kahler wrote:

This is a totally different approach: adding a hook after the generation of the message. This needs extra PHP code just to use a value already retrieved from the DB. Would have been nice if the different intention was mentioned here.

There were several different wishes for this message. Some wanted support for markers, others wanted other FE user fields in it. Because felogin only retrieves a few fields from the database the most flexible solution is to add a hook. This gives the possibility to add marker sections, other marker systems, data from anywhere in the world, etc.

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7503

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7503