Project

General

Profile

Actions

Feature #17382

closed

Delete button in yellow warning box

Added by Lars Houmark over 17 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2007-06-13
Due date:
% Done:

0%

Estimated time:
PHP Version:
4.3
Tags:
Complexity:
Sprint Focus:

Description

There should be a delete button/link in the yellow warning box when the warning about the ENABLE_INSTALL_TOOL file is present. This gives the user a much easier way of making the installation "secure" again.

(issue imported from #M5788)


Files

bug_5788.diff (1.79 KB) bug_5788.diff Administrator Admin, 2007-06-13 12:45
Actions #1

Updated by Michiel Roos over 17 years ago

Brilliant!

:-)

I like!

Actions #2

Updated by Martin Kutschker over 17 years ago

IMHO it would be better if the file could contain data for an IP check.

AFAIR it's not possible to chek in typo3/install/index.php, but there's plenty of room in typo3/init.php for such a check.

So I think a "restrict to IP" button (defaulting to the sessions IP number) is a better approach.

Actions #3

Updated by Michiel Roos over 17 years ago

I've heard about wireless people roaming around a building that get new IP's assigned while surfing. May also happen if one wireless station becomes less powerfull than another all of a sudden and the machine decides to reconnect.

So, I don't know about IP, but some hash value in a session cookie would do.

Actions #4

Updated by Martin Kutschker over 17 years ago

You can allow one or more addresses and address ranges. I'm not suggesting to check if the address changes in the session, but to recheck every time if it allowed. That's what is done for the normal IP check for the BE.

Actions #5

Updated by Benni Mack about 17 years ago

I don't think we need a IP check for it. Every admin should have the possibility to delete it (well, an admin has all rights). And it's not that if you delete it, it's the end of the world since most admins have file system access where they can create the file again. just my two cents.
So, I'd keep it easy and simple.

Actions #6

Updated by Martin Kutschker about 17 years ago

You don't have file access check everywhere (shared hosts), but you can circumvent the problem with some extensions :-)

Actions #7

Updated by Benni Mack over 16 years ago

Is already in the latest version, so this bug can be set to resolved.

Actions

Also available in: Atom PDF