TYPO3 Core

sry guys, the fix doesn't work. it removes a parse_url-error but left some other problems.

When comparing the shortcutlinks after clickmenu and the normal call only returnUrl is different.
correct: /t3/trunk/altdoc.php?...
wrong: http://localhost/t3/trunk/altdoc.php?...

I just stumbled across the same issue in 4.2.1 when creating a shortcut to a backend group.

As in Steffen's note, removing the http://hostname works fine.

So a quick fix might be something like this:

$url = preg_replace("/http:\/\/[^\/]*/", "", $url);

But of course it'd be better to remove it from the start.

somebody wants to create a patch for this?

I just added a small patch which removes http protocol parts from the shortcut's URI before inserting it into the db.

I'm still not sure if that's a good place or if one should search for all places where absolute URLs are used in the backend. I assume that those could all be replaced with local absolute urls (leading slash). Sounds cleaner to me right now.

I'm on the run now, maybe I can check that out later. Or someone else, as I have no idea of where to start ;-)

your patch doesn't solve the problem, parse_url-error still exists.

Fortunally i found the problem and fixed it with attached patch, so please test this.
The patch fixes 2 bugs

1) in ajax call for createShortcut: $_GET['url'] should not go through urldecode
2) bug in creating the links for the docHeader-buttons upload & new, where htmlspecialchars was used instead of rawurlencode

I still think that it might be a good idea to replace all absolute links to the current host with local absolute links. The hostname may change for various reasons (e.g. http vs. https, www. vs no www., test vs live environment, etc).

Any opinion on that?

i don't have any host-entries after the patch

ok, now i found the host.

The problem is, that normally REQUEST_URI is used for returnUrl, which doesn't contain the host.
In JS the property document.location is used, which contains the host.

All urls in Clickmenu are using the JS-Method, but fortunally they use top.rawurlencode, so this is the place where i extract the host from urls:

var host = "' . t3lib_div::getIndpEnv('TYPO3_REQUEST_HOST') . '";
str = str_replace(host,"",str);

so this is part 1 of my new patch

part 2/3 is in Ajaxcall for create shortcut.
2) url doesn't have to be urldecoded here
3) for edit links $shortcut['recordid'] holds the pageId which has to be used for the shortcut label

attached is the latest patch: 8305_shortcut3.diff

I tried running the patch on a fresh 4.2.2 and trunk version but it gives errors on both systems..

Tried running it with patch on ubuntu linux, patch on windows and tortoisesvn on windows. Nothing works.

Attached new

8205_shortcut4.diff (for trunk)
8205_shortcut4_4.2.diff (for 4.2-branch)

to fix failing hunks in 8205_shortcut3.diff. No logic change. Please retest.

i attached a new patch takeing Jeffs advices into account

committed v5 to trunk, rev 4591/92