Bug #18901

XHTML Validation Problems on Forgot Password Form

Added by Jeff Segars about 12 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Should have
Category:
felogin
Target version:
-
Start date:
2008-06-03
Due date:
% Done:

100%

TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The forgot password form has a minor XHTML validation problem when using the default template.

Both the label "for" attribute and the input ID are tied to ###FORGOT_EMAIL### (as is the input "name" attribute"). This marker evaluates as "tx_felogin_pi1[forgot_email]", but the brackets are not allowed in the ID or "for" attribute.

Changing the ID to forgot-email or something like that should clear up the issue, although it may introduce some small compatibility problems for people hooking CSS or Javascript onto the existing ID.

(issue imported from #M8600)

Associated revisions

Revision fed4435e (diff)
Added by Jigal van Hemert about 8 years ago

[BUGFIX] Validation problem in forgot and change password form

Label for attribute is invalid for XHTML. Changing it to a hard coded
value solves the problem. In case custom styling or Javascript breaks
the whole template can be replaced.

Change-Id: I41008125706f51104ff5ddf16786f0d7a71cf2af
Fixes: #18901
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/7514
Reviewed-by: Oliver Klee
Reviewed-by: Sebastian Michaelsen
Tested-by: Sebastian Michaelsen
Reviewed-by: Andy Grunwald
Tested-by: Andy Grunwald
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 19d74fc3 (diff)
Added by Jigal van Hemert about 8 years ago

[BUGFIX] Validation problem in forgot and change password form

Label for attribute is invalid for XHTML. Changing it to a hard coded
value solves the problem. In case custom styling or Javascript breaks
the whole template can be replaced.

Change-Id: Ib12bc9664e4f8d833c3534b68f01f2f8cc234afc
Fixes: #18901
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/10222
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1 Updated by Jigal van Hemert over 8 years ago

  • Assignee changed from Steffen Kamper to Jigal van Hemert
  • Target version deleted (0)
  • TYPO3 Version set to 4.5

#2 Updated by Jigal van Hemert over 8 years ago

  • Status changed from Accepted to Under Review

A patch is available for review: https://review.typo3.org/7514

(Somehow Gerrit didn't update this issue)

#3 Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7514

#4 Updated by Gerrit Code Review about 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7514

#5 Updated by Gerrit Code Review about 8 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7514

#6 Updated by Gerrit Code Review about 8 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10222

#7 Updated by Jigal van Hemert about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Gerrit Code Review about 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10290

#9 Updated by Wouter Wolters almost 8 years ago

Merged in 4.7.0rc2

#10 Updated by Ernesto Baschny almost 8 years ago

  • Status changed from Under Review to Closed
  • TYPO3 Version changed from 4.5 to 4.7

Also available in: Atom PDF