TYPO3 Core

Hi Franz,

did you test/profile this? Current there's a reference "&$labelValue" used that points to the accordant array item.
Could please explain, what your "$LOCAL_LANG Pos2" example above shows us? Thanks!

olly

Hello Olly,

this example shows the debug output of the total read in locallang.xml file. This is the result returned from the function readLLXMLfile which has been called from tx_div2007_alpha::loadLL_fh001($pibaseObj,'EXT:'.TT_PRODUCTS_EXTkey.'/pi_search/locallang.xml');
which itself calls
$tempLOCAL_LANG = t3lib_div::readLLfile($basePath,$langObj->LLkey);

You can see that the default part has read in everything twice. One is too much and also useless.

Franz

in TYPO3 4.2.2 you have had:
if (is_array($LOCAL_LANG[$langKey]) && $targetCharset!='utf-8') {
foreach($LOCAL_LANG[$langKey] as $labelKey => $labelValue) {
$LOCAL_LANG[$langKey][$labelKey] = $csConvObj->utf8_decode($labelValue,$targetCharset);
}
}
which seems to be ok.

Hey Franz.

Let me know if the attached patch fixes your problem.

Not sure if this actually "resolves" something (which I doubt). So I didn't reference this bug in the "Resolves"-line.
But using references for foreach()-values is a nice cleanup anyway.
Idea used in cleanup at: http://review.typo3.org/2791