Bug #19925

IFSUB and friends are ignoring the l18n_cfg field of the page record

Added by Stefan Galinski over 13 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2009-01-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The l18n_cfg field is used to disable the default language record or any alternative language records which haven't a page translation. At the first glance it seems to work like expected, because the expected page records are not visible in the menu. If we have a closer look at this part, we will find out that it's badly ignored for the record states IFSUB and friends. This causes that a page record which has no visible sub pages is marked with the IFSUB state.

How to reproduce?

1) Create the following page structure:

- first parent page
- first sub page
- second parent page
- first sub page

2) Add a translation for each of the parent records
3) Set the l18n_cfg field to each of the sub pages (it's not really important which setting or combintation)
4) Create a menu with IFSUB states applied
5) Test the result in the frontend
(issue imported from #M10285)


Files

typo3_10285.patch (1.67 KB) typo3_10285.patch Administrator Admin, 2009-01-27 16:25
10285_4.3.1.patch (1.67 KB) 10285_4.3.1.patch Administrator Admin, 2010-01-15 15:56

Related issues

Related to TYPO3 Core - Bug #22190: HMENU with IFSUB, CURIFSUB and hidden subpagesResolved2010-02-25

Actions
Related to TYPO3 Core - Bug #17635: subpages l18n_cfg is ignored in JSMENUClosed2007-09-28

Actions
Has duplicate TYPO3 Core - Bug #19374: IFSUB is not handling the language selection properlyClosedChristian Kuhn2008-09-24

Actions
Has duplicate TYPO3 Core - Bug #23700: IFSUB is still not handling the language selection properlyClosedChris topher2010-10-10

Actions
#1

Updated by Stefan Galinski over 13 years ago

The bug report #17635 is related to this problem...

#2

Updated by Stefan Galinski over 13 years ago

The attached patch is against TYPO3 4.2.4...

#3

Updated by Michael Voehringer over 13 years ago

I have exactly the same error and the patch worked for me, see also Bug 0009423.

#4

Updated by Chris topher almost 12 years ago

This has not yet been sent to Core List.

#5

Updated by Martin Terber over 11 years ago

The attached patch is still necessary and still works in TYPO3 4.4.6
Can this be fixed in the upcoming release?
Anyone knows about 4.5?

#6

Updated by Stefan Galinski over 11 years ago

You should still use the patch.

#7

Updated by Andreas Otto † over 11 years ago

  • Target version deleted (0)

Why is the state of this issue Needs Feedback?
What feedback is required to get this issue solved?

Target versions should be IMHO 4.4.8, 4.5.3, 4.6.0.

#8

Updated by Ernesto Baschny over 11 years ago

  • Category changed from Communication to Frontend
  • Status changed from Needs Feedback to Accepted
  • Target version set to 1061

No feedback is required, just someone to push it to Gerrit and some guys to review that.

After submit to master, it should also be backported to at least 4.5 and probably also the 4.4 branch. If the same patch applies to 4.3 too, would also be a candidate "while someone is at it".

#9

Updated by Oliver Hader about 11 years ago

  • Target version changed from 1061 to 1264
#10

Updated by Martin Terber about 11 years ago

The attached patch is still necessary and still works in TYPO3 4.5.3
Kind of a bummer, as the patch already exists why has it not been sent to core list yet?

#11

Updated by Steffen Gebert about 11 years ago

Mateng, could you please just do that? Tutorial

#12

Updated by Martin Terber about 11 years ago

Sure, I will.

#13

Updated by Steffen Gebert about 11 years ago

Great! If you run into trouble, just ask on the typo3-dev or typo3-teams-core mailing list!

#14

Updated by Oliver Hader about 11 years ago

  • Target version changed from 1264 to 1341
#15

Updated by Mr. Hudson almost 11 years ago

Patch set 1 of change I10e86761b13c61161ae3153b2b7612701e3743b7 has been pushed to the review server.
It is available at http://review.typo3.org/5265

#16

Updated by Mr. Hudson almost 11 years ago

Patch set 1 of change Iba596db44e5096d18e82757ea60a9042941719b8 has been pushed to the review server.
It is available at http://review.typo3.org/5266

#17

Updated by Mr. Hudson almost 11 years ago

Patch set 1 of change Ia988dfeb272b6c64c86c45f9d80b8b9299a09bfc has been pushed to the review server.
It is available at http://review.typo3.org/5573

#18

Updated by Martin Terber almost 11 years ago

Steffen Gebert wrote:

Great! If you run into trouble, just ask on the typo3-dev or typo3-teams-core mailing list!

Well, I actually ran into trouble, but didn't have the time to articulate the problems.
Thanks to Mr. Hudson for pushing this. Next time it's on me :).

#19

Updated by Mr. Jenkins over 10 years ago

  • Status changed from Accepted to Under Review

Patch set 2 of change Ia988dfeb272b6c64c86c45f9d80b8b9299a09bfc has been pushed to the review server.
It is available at http://review.typo3.org/5573

#20

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/5573

#21

Updated by Gerrit Code Review over 10 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/5573

#22

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/8938

#23

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/8939

#24

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_4-4 has been pushed to the review server.
It is available at http://review.typo3.org/8940

#25

Updated by Stefan Galinski over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#26

Updated by Ernesto Baschny about 9 years ago

  • Target version deleted (1341)
#27

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF