Project

General

Profile

Actions

Bug #19998

closed

Generation of encryption key does not work in IE7

Added by Bernd Gaspers almost 16 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2009-02-11
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Encryption key

"Generate random key" does not work in IE7

FireFox ok

(issue imported from #M10410)


Files

bug_10410_v2.diff (1.96 KB) bug_10410_v2.diff Administrator Admin, 2009-02-14 16:22
bug_10410_v3.diff (2.05 KB) bug_10410_v3.diff Administrator Admin, 2009-02-17 15:14
bug_10212_regression_v1.diff (1.3 KB) bug_10212_regression_v1.diff Administrator Admin, 2009-02-17 21:13
bug_10410_v4.diff (3.25 KB) bug_10410_v4.diff Administrator Admin, 2009-02-17 22:27
bug_10410_v5.diff (3.25 KB) bug_10410_v5.diff Administrator Admin, 2009-03-23 15:38

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #19875: Missing files in sysext installClosedSteffen Kamper2009-01-21

Actions
Related to TYPO3 Core - Bug #20379: Generate Random Key still does not workClosedRupert Germann2009-04-30

Actions
Actions #1

Updated by Steffen Müller almost 16 years ago

I can reproduce this with Firefox 3.0.6 on Ubuntu Intrepid, using TYPO3 core revision 5003 from trunk
The encryption key does not change at all, when the button is pressed.

4.0.12, 4.1.10, 4.2.6 work as expected.

It seems this was introduced with revision 4785, which fixes #19834, because revision 4784 works fine.
http://forge.typo3.org/repositories/diff/typo3v4-core?rev=4785

Seems like /typo3/sysext/install/mod/install.js and class.tx_install_eid.php are missing in trunk. Adding it fixes the issue for me (though not tested in IE7!)

Actions #2

Updated by Steffen Müller almost 16 years ago

I have just tested this with IE7
I'm sorry, my resolution and patch indeed fixes this issue for FF 3 on trunk.
But it does not resolve the originally reported bug with IE7.
I can reproduce the IE7 problem with 4.2.6

So my patch does resolve another bug, but not this one. Sh**!

Actions #3

Updated by Steffen Müller almost 16 years ago

Please reopen 10154.

Actions #4

Updated by Marcus Krause almost 16 years ago

Could we please agree, which TYPO3 version is broken??? This issue covers branch 4.2, but you are talking about trunk!

For sure there's a problem with trunk, see #19875

Actions #5

Updated by Steffen Müller almost 16 years ago

Sorry, I was too tired yesturday. Forget about my last three postings...

After testing again, here's my result:

4.0.12:
IE7, IE6, FF2, FF3: popup appears, which tells me to copy/paste the encryption key.

4.1.10:
FF2, FF3: ok
IE6: Error: Encryption key is undefinded
IE7: Error: 'EncryptionKey' ist undefiniert (=config,210)

4.2.6:
FF2, FF3: ok
IE6: Error: Encryption key is undefinded
IE7: Error: 'EncryptionKey' ist undefiniert (=config,206)

Actions #6

Updated by Marcus Krause almost 16 years ago

Maybe you are able to provide a patch? ;-)

Actions #7

Updated by Steffen Müller almost 16 years ago

Unfortunately, I am not: JavaScript = void()
But I could test a patch on these browsers ;-)

Actions #8

Updated by Marcus Krause almost 16 years ago

And I don't have access to IEs. I guess we have to wait for somebody else fixing it.

Maybe you want to comment on #19875 pending in core list, so that at least this issue gets resolved?

Actions #9

Updated by Bernd Gaspers almost 16 years ago

Leider hat der bug_10410.diff nichts gebracht.
Unter IE 7 geht leider nicht "Generate randon key"

Fehlermeldung IE

Zeile: 209
Zeichen: 1
Fehler: EncrptionKey ist undefiniert
Code: 0
URL: http://domain/typo3/install/index.php?TYPO3_INSTALL(type)=config

ohne das diff

Fehlermeldung IE

Zeile: 48
Zeichen: 3
Fehler: Bezeichner,Zeichenfolge oder Zahl erwartet
Code: 0
URL: http://domain/typo3/install/index.php?TYPO3_INSTALL(type)=config

Sorry für Deutsch

Actions #10

Updated by Marcus Krause almost 16 years ago

Removed previously existing patch.
That patch was a copy of one added to #19875. It was not in any way related to this issue!

Actions #11

Updated by Steffen Müller almost 16 years ago

Marcus, could you please raise priority on this issue, because it discourages IE users from changing encryption key in a security related situation.

Actions #12

Updated by Steffen Kamper almost 16 years ago

i changed the patch so it works with IE, see core list.

Actions #13

Updated by Steffen Müller almost 16 years ago

Added new patch - according to Steffen Kampers fix for #19875, which is trunk only.

Bernd, please also test the diff file.

Actions #14

Updated by Steffen Kamper almost 16 years ago

resolved with #19875

Actions #15

Updated by Steffen Kamper almost 16 years ago

fixed only for trunk

Actions #16

Updated by Bernd Gaspers almost 16 years ago

i have load trunk 5021 /trunk/typo3/sysext/install
it dont work in IE7 and FF3
click after "Generate random key" the field is empty

i load this night complet 5021 and test it

Actions #17

Updated by Marcus Krause almost 16 years ago

Please clear browser cache before testing!

trunk should work in IE; it definetly works in FF and Opera on RHEL5

Actions #18

Updated by Bernd Gaspers almost 16 years ago

i have load trunk 5021

ff3 OK

sorry for German

im IE7 kommt immer wieder "829fc4add630d66dee........".

Actions #19

Updated by Steffen Kamper almost 16 years ago

sry, tested latest trunk in IE7 - works as expected, generate a new key for each click.

Actions #20

Updated by Bernd Gaspers almost 16 years ago

i have load trunk 5023

es wird ein key erzeugt, wenn ca. unter 1 Stunde nochmal der Buton gedrückt wird keine Reaktion, nach über einer Stunde Wartezeit geht es wieder. grübel

Auf verschiedene Server getestet.

Im FF3 geht es sofort.

Sorry 4.3dev inst schäm

Actions #21

Updated by Steffen Müller almost 16 years ago

Added new patch v3 which changes ajax request from get to post. This resolves caching issues with IE and finaly should fix the issue.

Actions #22

Updated by Bernd Gaspers almost 16 years ago

Danke
its work in TYPO3 4.2.6 and TYPO3 trunk 5023

Actions #23

Updated by Marcus Krause almost 16 years ago

Bernd, we could reproduce your problem. It's a caching problem in IE.
We're trying to prevent POST requests and would rather stay with GET ones.

I hereby attach a new patch. Please try the new patch (bug_10212_regression_v1.diff) together with trunk.

Actions #24

Updated by Steffen Müller almost 16 years ago

I merged all changed to one new patch: bug_10410_v4.diff

Actions #25

Updated by Bernd Gaspers almost 16 years ago

bug_10410_v4.diff its ok at 4.2.6 and IE7, IE8

Actions #26

Updated by Marcus Krause almost 16 years ago

great, finally

So we just need to collect +1 s to get this committed.

Actions #27

Updated by Jeff Segars over 15 years ago

Committed v5 patch to 4.1 (r5218) and 4.2 (r5219).

Actions

Also available in: Atom PDF