Project

General

Profile

Actions

Bug #20231

closed

Small rendering/css bug on FE with Text with image

Added by Clemens Riccabona over 15 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2009-03-23
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you have a CE 'Text with Images' and set the positioning to 'Image left in Text' where the text should float around the image and you put in an image and as text just an ordered or unordered list, these lists have not the correct padding on the left hand side.
This occurs on FF3 as well as on IE7, which have about 70% of users all over europe.

I made a clean T3 installation with Version 4.2.6, Added a page to the pagetree, added a template for a new site, added one of the static templates (i tested several of them, e.g. 'green') and add css_styled_content.
Produce a CE 'Text with images' add an image an as text add an ordered or unordered list. As orientation of the media choose the floating 'in text left'.
Look at the FE.

I tested it with several of the standard templates (Hyper, Green, Bug, TU) as well as on several of my own pages. everywhere the same bug.

As a quick and dirty solution I used following in my CSS:

.csc-textpic-intext-left .csc-textpic-text ul, .csc-textpic-intext-left .csc-textpic-text ol { position:relative;left:20px; }

because the paddings and margins I tried had no effect (at least on FF3)
(issue imported from #M10768)


Files

css_styled_content.diff (669 Bytes) css_styled_content.diff Administrator Admin, 2009-03-26 23:40
bug10768-firefox-BUG.png (11.5 KB) bug10768-firefox-BUG.png Administrator Admin, 2009-05-15 16:30
bug10768-firefox-OK.png (113 KB) bug10768-firefox-OK.png Administrator Admin, 2009-05-15 16:30
bug10768-nobullets-buggy.png (24.1 KB) bug10768-nobullets-buggy.png Administrator Admin, 2009-09-15 11:09
bug10768-nobullets-fixed.png (22.6 KB) bug10768-nobullets-fixed.png Administrator Admin, 2009-09-15 11:09
10768_followup.diff (1.13 KB) 10768_followup.diff Administrator Admin, 2010-04-25 23:24
10768-padding-left-bug.png (77.1 KB) 10768-padding-left-bug.png Administrator Admin, 2010-04-27 10:11
Actions #1

Updated by Patrick Broens over 15 years ago

Added a patch file

Actions #2

Updated by Patrick Broens over 15 years ago

Added to the core list

Actions #3

Updated by Patrick Broens over 15 years ago

Committed to trunk,
rev 5228 for trunk
rev 5229 for 4.2 branch

Actions #4

Updated by Ernesto Baschny over 15 years ago

The new CSS does indeed interfere with the rendering of these images in Firefox / Safari (see attached images of the effect).

Actions #5

Updated by Ernesto Baschny over 15 years ago

bug10768-firefox-BUG.png = with this fix applied
bug10768-firefox-OK.png = removing the new CSS line from the code

Actions #6

Updated by Clemens Riccabona over 15 years ago

I tested now on FF 3.5., IE8, Opera 9.64, all on a win XP, all within a TYPO3 4.2.6:

For me the patch works fine. ;)

Actions #7

Updated by Ernesto Baschny about 15 years ago

Ok, I had the next side effect of this fix on another site. The effect was that bullets inside text-with-image text-elements were missing. See attached files:

bug10768-nobullets-buggy.png
bug10768-nobullets-fixed.png = without the new CSS lines

So I can imagine that I am not the only one that has strange side effects by the fix.

I must say that the original problem (missing bullets besides floated images) is known and annoying to me, but I think the commited fix is not really better. Better leave those fixes to CSS of site implementators and keep our provided CSS simple.

Actions #8

Updated by Susanne Moog over 14 years ago

Just tested the current trunk:
No problems anymore in FF 3.6, Chrome (both on Ubuntu), IE6 (XP) and IE7 (Vista) and everything seems to be fine.

Actions #9

Updated by Helmut Hummel over 14 years ago

Attached a patch which fixes the issue in FF2-3.6, Safari 4 and still works in IE 6,7

Actions #10

Updated by Ernesto Baschny over 14 years ago

Helmut, looks nice! See comments in the core list.

For the record: I still don't totally like the UL-bullets-fix solution, as the "40px padding-left" might affect the positioning of regular UL-lists in that context (when there is no more images to the left of the text). This happens when the users-CSS contains something like:

ul { padding: 0; margin: 0 } /* css reset's usually do that /
ul { margin: 0.5em 0 0.5em 2em; } /
positioning by margins */

The padding-left is then added to the left of the ul. See screenshot attached (10768-padding-left-bug.png).

Actions #11

Updated by Susanne Moog over 14 years ago

follow up committed to trunk rev 7435

Actions #12

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF