Project

General

Profile

Actions

Bug #20339

closed

Output of additionalCSS not valid

Added by Alexander Grein about 15 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Could have
Category:
-
Target version:
Start date:
2009-04-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Remote Sprint

Description

Output of tslib_fe::INTincScript_loadJSCode() produes invalid markup: are not valid there.

SteffenG: We're talking english here ;)

Der in der Datei "class.tslib_fe.php" generierte additionalCSS-Code ist nicht valide, da die ausgegebenen Kommentarzeichen "
02659 /*]]>/
02660 </script>';
02661 }
02662 if ($this->JSCode || count($this->additionalJavaScript)) { // Add javascript
02663 $this->additionalHeaderData['JSCode']='
02664 <script type="text/javascript">
02665 /
<![CDATA[*/
02666
02670 /*]]>/
02671 </script>';
02672 }
02673 if (count($this->additionalCSS)) { // Add javascript
02674 $this->additionalHeaderData['_CSS']='
02675 <style type="text/css">
02676 /
<![CDATA[*/
02677
02680 /*]]>*/
02681 </style>';
02682 }
02683 }

NEU:
02673 if (count($this->additionalCSS)) { // Add CSS
02674 $this->additionalHeaderData['_CSS']='
02675 <style type="text/css">
02676 /*<![CDATA[*/
02677
02678 '.implode(chr(10),$this->additionalCSS).'
02679
02680 /*]]>*/
02681 </style>';
02682 }

(issue imported from #M10955)


Files

10955.diff (565 Bytes) 10955.diff Administrator Admin, 2011-02-05 11:23
Actions #1

Updated by Alexander Opitz about 11 years ago

  • Status changed from New to Needs Feedback
  • Target version deleted (0)
  • TYPO3 Version set to 4.2

The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?

Actions #2

Updated by Riccardo De Contardi about 11 years ago

as far as I can see, comments are still present in TYPO3 4.7.11, in
typo3/sysext/cms/tslib/class.tslib_fe.php line 3373

and in 6.1:
typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php line 3516

see http://www.webdevout.net/articles/escaping-style-and-script-data for reference

Actions #3

Updated by Alexander Opitz almost 11 years ago

  • Status changed from Needs Feedback to New
  • Priority changed from Should have to Could have
Actions #4

Updated by Mathias Schreiber over 9 years ago

  • Assignee set to Mathias Schreiber
  • Target version set to 7.1 (Cleanup)
  • Is Regression set to No
  • Sprint Focus set to Remote Sprint
Actions #5

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36028

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36028

Actions #7

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36028

Actions #8

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36031

Actions #9

Updated by Mathias Schreiber over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF