Bug #20339
closedOutput of additionalCSS not valid
100%
Description
Output of tslib_fe::INTincScript_loadJSCode() produes invalid markup: are not valid there.
SteffenG: We're talking english here ;)
Der in der Datei "class.tslib_fe.php" generierte additionalCSS-Code ist nicht valide, da die ausgegebenen Kommentarzeichen "
02659 /*]]>/
02660 </script>';
02661 }
02662 if ($this->JSCode || count($this->additionalJavaScript)) { // Add javascript
02663 $this->additionalHeaderData['JSCode']='
02664 <script type="text/javascript">
02665 /<![CDATA[*/
02666
02670 /*]]>/
02671 </script>';
02672 }
02673 if (count($this->additionalCSS)) { // Add javascript
02674 $this->additionalHeaderData['_CSS']='
02675 <style type="text/css">
02676 /<![CDATA[*/
02677
02680 /*]]>*/
02681 </style>';
02682 }
02683 }
NEU:
02673 if (count($this->additionalCSS)) { // Add CSS
02674 $this->additionalHeaderData['_CSS']='
02675 <style type="text/css">
02676 /*<![CDATA[*/
02677
02678 '.implode(chr(10),$this->additionalCSS).'
02679
02680 /*]]>*/
02681 </style>';
02682 }
(issue imported from #M10955)
Files
Updated by Alexander Opitz over 11 years ago
- Status changed from New to Needs Feedback
- Target version deleted (
0) - TYPO3 Version set to 4.2
The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?
Updated by Riccardo De Contardi over 11 years ago
as far as I can see, comments are still present in TYPO3 4.7.11, in
typo3/sysext/cms/tslib/class.tslib_fe.php line 3373
and in 6.1:
typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php line 3516
see http://www.webdevout.net/articles/escaping-style-and-script-data for reference
Updated by Alexander Opitz over 11 years ago
- Status changed from Needs Feedback to New
- Priority changed from Should have to Could have
Updated by Mathias Schreiber over 9 years ago
- Assignee set to Mathias Schreiber
- Target version set to 7.1 (Cleanup)
- Is Regression set to No
- Sprint Focus set to Remote Sprint
Updated by Gerrit Code Review over 9 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36028
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36028
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36028
Updated by Gerrit Code Review over 9 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36031
Updated by Mathias Schreiber over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 60709184d6ee54b85f6f916490a2c3152e33bbc6.
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed