Bug #21056

Close Button is at the wrong place when editing a file in filelist

Added by Simon Schaufelberger about 10 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2009-09-15
Due date:
% Done:

0%

TYPO3 Version:
4.2
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When editing a file via the file list browser, the close button is the third icon. everywhere else it is the first one except here. for consistency i would suggest to move it to the first position as well

(issue imported from #M11957)

11957.diff View (585 Bytes) Administrator Admin, 2010-11-01 19:51


Related issues

Related to TYPO3 Core - Feature #18148: add docheader to file -> filelist module Closed 2008-02-07

History

#1 Updated by Simon Schaufelberger about 9 years ago

change in file "typo3/templates/file_edit.html" the following lines to this:

<!-- ###BUTTON_GROUPS_LEFT### -->
<!-- ###BUTTON_GROUP1### -->###CANCEL###<!-- ###BUTTON_GROUP1### -->
<!-- ###BUTTON_GROUP2### -->###SAVE######SAVE_CLOSE###<!-- ###BUTTON_GROUP2### -->
<!-- ###BUTTON_GROUPS_LEFT### -->

#2 Updated by Chris topher about 9 years ago

Hi Simon,

can you make apatch file with your changes and send that to Core List?
That would be great!
For more information see here: http://typo3.org/teams/core/core-mailinglist-rules

#3 Updated by Simon Schaufelberger about 9 years ago

Hi Christopher,
can you tell me why this is so complicated?
I mean, i can just upload here the patch file, why does it need to go through the mailing list as well?

#4 Updated by Chris topher about 9 years ago

Hmm, it is the standard review process for every change to the Core. It has nothing to do with your patch in special.
Most changes are not that obvious. Therefore a place is needed to conveniently discuss things and also later to be able to look up why things where done the way they were finally done. This can be done better on a mailing list instead of in a bugtracker.

But in case of obvious changes this is no obstacle; things are dealt with rather quickly and uncomplicatedly.

Just send the mail with your patch and you will see!

#5 Updated by Steffen Gebert about 9 years ago

Simon, please have a look at http://typo3blogger.de/ab-in-den-core/ , where I described the process (in German).

#6 Updated by Steffen Gebert about 9 years ago

Committed to trunk rev. 9240

Thanks for your first contribution, Simon!

#7 Updated by Susanne Moog over 8 years ago

  • Target version deleted (4.5.0)

Also available in: Atom PDF