Bug #21148

Permanent login checkbox is not shown as expected

Added by Stefan Froemken over 11 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Category:
felogin
Target version:
-
Start date:
2009-09-29
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If $GLOBALS['TYPO3_CONF_VARS']['FE']['permalogin'] is set to 2 and $GLOBALS['TYPO3_CONF_VARS']['FE']['lifetime'] is greater than 0, then no checkbox for permalogin appears.
$GLOBALS['TYPO3_CONF_VARS']['FE']['permalogin'] = 2 means: Permanent login is forced to be enabled

In class.tx_felogin_pi1.php I found this:

if (($this->conf['showPermaLogin']) && ($GLOBALS['TYPO3_CONF_VARS']['FE']['permalogin'] 0 || $GLOBALS['TYPO3_CONF_VARS']['FE']['permalogin'] 1) && $GLOBALS['TYPO3_CONF_VARS']['FE']['lifetime'] > 0) {

on line 496

but there is no IF for permalogin = 2!
(issue imported from #M12072)


Files

12072.diff (4.27 KB) 12072.diff Administrator Admin, 2009-12-05 20:56
12072_v2.diff (1.01 KB) 12072_v2.diff Administrator Admin, 2009-12-09 10:11
12072_v3.diff (1023 Bytes) 12072_v3.diff Administrator Admin, 2009-12-10 11:10

Related issues

Related to TYPO3 Core - Bug #19031: showPermaLogin = 1Closed2008-06-27

Actions
#1

Updated by Xavier Perseguers over 11 years ago

Actually, there is a bug there. Permanent login should be activated in localconf.php:

(according to config_default.php):

// -1: Permanent login for FE users disabled
// 0: By default permalogin is disabled for FE users but can be enabled by a form control in the login form
// 1: Permanent login is by default enabled but can be disabled by a form control in the login form
// 2: Permanent login is forced to be enabled: Nothing to do

In addition lifetime should be greater than 0 (value in sec).

value 1 does not make sense as it is not possible to deactivate the login. Instead I propose to change its definition so that 0 = disabled but can be enabled by a form control, and 1 = may be globally activated or activated using a form control

#2

Updated by Xavier Perseguers over 11 years ago

Actually, value 2 means the frontend cookie is always active for "lifetime". Those values are not meant to activate or deactivate the "show" of the checkbox in frontend but to tell how should the fe cookie be created. I misunderstood it and will provide a new patch soon.

#3

Updated by Xavier Perseguers over 11 years ago

Committed v3 to trunk (changeset 6646)
Committed v3 to branch 4-3 (changeset 6647)

#4

Updated by Xavier Perseguers over 11 years ago

Ingo, please report if I should commit the change to branch 4-2 as well. Thanks

#5

Updated by Dmitry Dulepov over 11 years ago

Btw, great bug report title.

#6

Updated by Xavier Perseguers over 11 years ago

Committed v3 to branch 4-2 (changeset 6665) after clearing bugfix policy with Ingmar

#7

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF