Bug #21361
closedUpdate required tables COMPARE doesn't work in 4.2.10
0%
Description
if i click on "COMPARE" i get redirected to the about section of the install tool :(
(issue imported from #M12342)
Files
Updated by Oliver Hader almost 15 years ago
Hi Dirk,
thus, you did not see any tables that needed changes and got redirected immediatelly after clicking the "COMPARE" link?
I could not reproduce this using Safari 4.0.3 and Firefox 3.5 with TYPO3 4.2.10.
Which browser are you using? Does your URL contain special characters (e.g. myhost.de/~username/sub-directory/ÜÖÄ/typo3/install/)?
Updated by Dirk Diebel almost 15 years ago
hello oliver,
strange. i checked that behaviour at my private typo3 installation and there it just works fine with 4.2.10, but on several installation at work it doesn't... i will have a closer look at it tomorrow.
Updated by Sebastian Schindler almost 15 years ago
Hi there,
i had the same problem. I have tryed with different browsers (opera, ff, konquerer, ie) and different version, always the the after clicked on "COMPARE".
Updated by Marcus Krause almost 15 years ago
I cannot reproduce this with latest revision of 4.2 branch (Opera) on a server that uses fcgid and suhosin.
Updated by Pavel Filippov almost 15 years ago
Hi
i had the same problem too. in addition - same problem in "Image Processing" by pressing test buttons. (clean install and update from 4.1.12 and 4.1.13)
4.2.9 work perfectly.
TYPO3 4.2.10, php 5.2
Updated by Christian Kuhn almost 15 years ago
After updating a bunch of 4.2 sites on different systems (most of them with suhosin +fcgid) with ff 3.5 this issue never happened to me, I'm unable to reproduce.
Could someone having this problem please try to track this down any further?
Updated by Ernesto Baschny almost 15 years ago
Could the reporter Dirk, Sebastian and Pavel please give us more details about your setup?
Which PHP versions, which OS, which webserver, which PHP-API is being used (mod_php, fastcgi, cgi, ...)? Do you have suhosin module enabled?
Updated by Pavel Filippov almost 15 years ago
SERVER_SOFTWARE Apache/1.3.34 (Debian)
GATEWAY_INTERFACE CGI/1.1
SERVER_PROTOCOL HTTP/1.0
PHP Version 5.2.0-8+etch15
System Linux server 2.6.18-6-686-bigmem #1 SMP Thu Aug 20 23:15:44 UTC 2009 i686
Server API CGI/FastCGI
Virtual Directory Support disabled
PHP API 20041225
PHP Extension 20060613
Zend Extension 220060519
Debug Build no
Thread Safety disabled
Zend Memory Manager enabled
IPv6 Support enabled
Registered PHP Streams zip
Registered Stream Socket Transports tcp, udp, unix, udg, ssl, sslv3, sslv2, tls
Registered Stream Filters string.rot13, string.toupper, string.tolower, string.strip_tags, convert.*, consumed, convert.iconv.*, bzip2.*, zlib.*
MySQL 5.0.32
suhosin not installed
-------------------------------------------
on this config 4.2.9 work, 4.2.10 - no
Updated by Ernesto Baschny almost 15 years ago
I was suspecting the FastCGI to be the cause, but I just tested on a FastCGI installation (on debian etch, PHP Version 5.2.0-8+etch15 which is the same as you) with pretty restrictive setting (open_basedir restriction, safe_mode=on, ...) and everything worked as expected.
Only difference is apache2 instead of apache1.3, but I doubt that this is the problem.
So I am currently helpless and need more input or someone that has the problem being able to figure it out where that bug comes from.
Maybe Pavel, you could post us the "session" part of the phpinfo() as shown in the Install Tool ("8: phpinfo()"). If this is too much disclosure for you, please send it to me at ernst@cron-it.de.
Updated by Dirk Diebel almost 15 years ago
this is my environment where it doesn't work with 4.2.10:
CONST: PHP_OS : Linux
CONST: TYPO3_OS :
CONST: php_sapi_name: apache2handler
OTHER: TYPO3_VERSION: 4.2.10
OTHER: PHP_VERSION : 5.1.6
OTHER: memory_limit : 128M
SERVER: SERVER_PORT : 80
SERVER: SERVER_SOFTW: Apache/2.2.3 (Oracle)
Updated by Ernesto Baschny almost 15 years ago
Dirk, so no fastCGI on your front? Could you please post us the "session" part of the phpinfo() as shown in the Install Tool ("8: phpinfo()")? Thanks!
Updated by Pavel Filippov almost 15 years ago
Hi,
It is that information which is necessary?
session
Session Support enabled
Registered save handlers files user sqlite
Registered serializer handlers php php_binary wddx
Directive / Local Value / Master Value
session.auto_start Off Off
session.bug_compat_42 On On
session.bug_compat_warn On On
session.cache_expire 180 180
session.cache_limiter nocache nocache
session.cookie_domain no value no value
session.cookie_httponly Off Off
session.cookie_lifetime 0 0
session.cookie_path / /
session.cookie_secure Off Off
session.entropy_file no value no value
session.entropy_length 0 0
session.gc_divisor 100 100
session.gc_maxlifetime 1440 1440
session.gc_probability 0 0
session.hash_bits_per_character 4 4
session.hash_function 0 0
session.name PHPSESSID PHPSESSID
session.referer_check no value no value
session.save_handler files files
session.save_path /tmp /tmp
session.serialize_handler php php
session.use_cookies On On
session.use_only_cookies Off Off
session.use_trans_sid 0 0
Updated by Dirk Diebel almost 15 years ago
Session Support enabled
Registered save handlers files user
Registered serializer handlers php php_binary wddx
Directive Local Value Master Value
session.auto_start Off Off
session.bug_compat_42 Off Off
session.bug_compat_warn On On
session.cache_expire 180 180
session.cache_limiter nocache nocache
session.cookie_domain no value no value
session.cookie_lifetime 0 0
session.cookie_path / /
session.cookie_secure Off Off
session.entropy_file no value no value
session.entropy_length 0 0
session.gc_divisor 100 1000
session.gc_maxlifetime 7200 1440
session.gc_probability 100 1
session.hash_bits_per_character 5 5
session.hash_function 0 0
session.name Typo3InstallTool PHPSESSID
session.referer_check no value no value
session.save_handler user files
session.save_path /opt/wwwroot/xxxxx.de/html/typo3temp//sessionsXXXXXXX /opt/wwwroot/phpsessions
session.serialize_handler php php
session.use_cookies On On
session.use_only_cookies Off Off
session.use_trans_sid 0 0
Updated by Ernesto Baschny almost 15 years ago
Thanks Dirk, I just edited your note to "anonymize" your save_path, I hope it is ok. :) And Pavel, you called phpinfo() from outside your Install tool, would you mind to call the "8: phpinfo()" from within the install tool?
Unfortunately at the first glance I cannot really see anything that might be problematic. :(
Updated by Sebastian Schindler almost 15 years ago
Serversetting: * Apache2 (2.2.3-4+etch10) * PHP 5.2 (5.2.0.8+etch15) * MySQL Server 5 (5.0.51a-3~bpo40+1) * Kernel 2.6.22-4-amd64 * CGI usage disabled * no suhosin * openbasedir restrictions activ * Zend Optimizer activ
session
Session Support enabled
Registered save handlers files user
Registered serializer handlers php php_binary wddx
Directive Local Value Master Value
session.auto_start Off Off
session.bug_compat_42 Off Off
session.bug_compat_warn On On
session.cache_expire 180 180
session.cache_limiter nocache nocache
session.cookie_domain no value no value
session.cookie_httponly Off Off
session.cookie_lifetime 0 0
session.cookie_path / /
session.cookie_secure Off Off
session.entropy_file no value no value
session.entropy_length 0 0
session.gc_divisor 100 1000
session.gc_maxlifetime 7200 1440
session.gc_probability 100 1
session.hash_bits_per_character 5 5
session.hash_function 0 0
session.name Typo3InstallTool PHPSESSID
session.referer_check no value no value
session.save_handler user files
session.save_path /srv/www/htdocs/domain.tld/typo3temp//sessions66b8473be4fcdcad02ceaa34af3f0b97 /var/lib/php5
session.serialize_handler php php
session.use_cookies On On
session.use_only_cookies Off Off
session.use_trans_sid 0 0
Updated by Peter Niederlag almost 15 years ago
This might(?) depend on the php version? At least it turns out to be an issue with 't3lib_div::stripSlashesOnArray()' and references.
lines 262 through 288 of 'typo3/sysext/install/class.tx_install.php' take care of validationg $_GET params.
On some occasions it seems that this is the offending line:
----------------------------------
$this->INSTALL['type'] = '';
----------------------------------
It probably also unsets the corresponding superglobal $_GET (due to stripSlashesOnArray()'s usage of reference I would assume?)
I woudl suggest to move this line somewhere else or just cleanup the processing a little bit.
Updated by Peter Niederlag almost 15 years ago
- to reproduce:
// within t3lib_div::_GP('TYPO3_INSTALL'); stripslahesOnArray89 is used which in turn uses references
// so we might end up with a refence in $this->INSTALL?
$this->INSTALL = t3lib_div::_GP('TYPO3_INSTALL');
// anyway afzter this line:
$this->INSTALL['type'] = '';
// type has vanished from $_GET
t3lib_div::_GP('TYPO3_INSTALL')
- PHP Version 5.1.6 #
Updated by Ernesto Baschny almost 15 years ago
Hey Peter, thanks for following that up and tracking that down!
This might be indeed the reason, I still haven't tested it. But as soon as I saw you mentioning stripSlashesOnArray(), I remembered my #20995, which is exactly about that problem in the optimized stripSlashesOnArray in 4.2 (using foreach instead of while) and the side-effect which affected us already on a totally different place (sr_feuser_register). But it seems now that we could have found another side-effect.
So I welcome people having the problem to please try the patch attached to #20995 (11876.diff) to see if the problem disappears. If it does, please send a "+1" for this RFC which has been pending in core now for ages and noone really understood the problem or the fix.
Thanks!
Updated by Sebastian Schindler almost 15 years ago
This fix works fine for my Installation. Thanks guys.
While I am here the first time I do not know what you mean with "send a +1 for this RFC". Could you please explain this for me?
Updated by Ernesto Baschny almost 15 years ago
Commited to trunk rev. 6328 (4.3 beta3) and TYPO3 4.2 rev 6329 (4.2.11).