Project

General

Profile

Actions

Bug #21396

closed

sys_refindex can't handle linkhandler links correctly

Added by Michael Klapper over 14 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2009-10-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Problem:
The "t3lib_softrefproc" handle the linkhandler values as type of "_STRING" and that is wrong.

The linkhandler should provide the logic to extract the reference to their records if there any.

Solution:
The "t3lib_softrefproc" needs a detection for linkhandler references so that they can handled by the linkhandler itself.

Therefore i suggest two hooks and a new small method to detect linkhandler values.

Note:
If there is no way to keep the sys_refindex up to date you can't clean your environment using the lowlevel_cleaner.

(issue imported from #M12389)


Files

12389.patch (2.68 KB) 12389.patch Administrator Admin, 2009-10-29 09:41
Actions #1

Updated by Oliver Hader over 14 years ago

Hi Mick,
could you please provide a short information on how to test this issue? I don't think that it would be easy to write unit tests in this scenario... Thanks in advance!

Actions #2

Updated by Michael Klapper over 14 years ago

How to reprocue it: ===============
- Use current linkhandler version from TER http://typo3.org/extensions/repository/view/linkhandler/current/
1) Go to your tt_content element with the uid XY and create a link to an record using the linkhandler extension (e.q. record:tt_news:10)
2) Open you bash and run "time php -d memory_limit=512M typo3/cli_dispatch.phpsh lowlevel_refindex -e"
3) Open the info dialog on the tt_content element with the uid XY where you created the linkhandler link. There you can see the link entry as type "_STRING", this means that no valid relation from the record to the tt_news record exist in the table sys_refindex.


After applying the patch or just installing the latest linkhandler from trunk https://svn.typo3.org/TYPO3v4/Extensions/linkhandler/trunk/ (the linkhandler provide a XCLASS to add the hooks).

1) Run the "lowlevel_refindex " again and refresh the info dialog. Now you can see that there a valid reference to the tt_news record with the uid 10 exists.
2) Go to the tt_news record with the uid 10 open the info dialog of that record and you should see the back reference to the tt_news record XY who linked te the this record.

=======================================

If you need more details just add me a note.

Thanks,
Mick

Actions #3

Updated by Alexander Opitz about 11 years ago

  • Status changed from New to Needs Feedback
  • Target version deleted (0)

The issue is very old, does this issue exists in newer versions of TYPO3 CMS (4.5 or 6.1)?

Actions #4

Updated by Ralf Hettinger about 11 years ago

Yes it is still an issue. And related to #46140 - should imo be solved with #46140.

Actions #5

Updated by Alexander Opitz about 11 years ago

Which TYPO3 CMS version did you test?

Actions #6

Updated by Alexander Opitz over 10 years ago

  • Is Regression set to No

Can you tell me, with which version do you test the issue?

Actions #7

Updated by Ralf Hettinger over 10 years ago

There is currently no proper test setup, since the linkhandler extension is afaik not compatble with current versions. This extension is hopefully meant to be integrated into the Core (#46140). Before this isn't the case, it is only testable with 4.5 using the linkhandler from Ext Manager.
So I'd suggest to leave this one here open until #46140 is solved to not forget compatiblity with the Reference Index.

Actions #8

Updated by Alexander Opitz over 10 years ago

  • Category set to Backend API
  • Status changed from Needs Feedback to New
Actions #9

Updated by Gerrit Code Review about 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27746

Actions #10

Updated by Alexander Stehlik about 10 years ago

Example implementation for testing can be found here:

https://github.com/Intera/typo3-extension-linkhandler

Actions #11

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27746

Actions #12

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27746

Actions #13

Updated by Gerrit Code Review almost 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31423

Actions #14

Updated by Alexander Stehlik almost 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #15

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF