Recycler produces some scroll bars
The recycler produces some scrollbars and this look a bit ugly.
- the recycler should use the whole dimension available in the viewport (no hardcoded dimensions)
- the "recycler" title is not required
- the "delete" and "undelete" buttons should be inside the panel and not below
See the attached screenshot at a resolution of 1024x768 in Firefox 3 - even the action buttons below the panel are not visible.
(issue imported from #M12437)
#3 Updated by Steffen Kamper over 10 years ago
I disagree with the title, each module (except list) has the title at the beginning. Why should it be omitted?
I agree with styling. Header should be aligned left, tab isn't needed (there is only one). So i suggest something like that
allows to undelete deleted data
I try to put the buttons inside too.
#4 Updated by Steffen Müller over 10 years ago
I conform the patch fixes 2) and 3)
But regarding 1) there is still one scrollbar too much, at last when using a screen resolution of 1280x800 (14.1 '' screen) - even if I use browser in fullscreen mode (see appended screenshot: recycler_scrollbar-2.png)
It seems that the reason is the height of the div container #recyclerContent which is too big.
#6 Updated by Steffen Müller over 10 years ago
Please have a look at my screenshot. I meant the outer scrollbar. The inner one is totally ok, since the list of items is longer than the grid. But the outer one is useless.
I can't test behavior with few items (lines), because the grid does not shrink (see #21440).
A general solution would be the make the container resizeable and have some auto resizing to fit the frame. Just like you did with textareas in tt_content. Setting a records limit via userTS is no solution, since this is not an option for unprivileged users.
#9 Updated by Steffen Kamper over 10 years ago
here is v2 which is the result of my rework.
There are 2 TODOs which i postpone for later, as i was not able to achieve now:
1) automatic resizing of columns when window is resized
2) better alignment for toolbar (i would like to have 2 groups left/right aligned)
But i think it's much better than before.
#10 Updated by Steffen Müller over 10 years ago
Thanks for the patch. I appended a screenshot of how it looks on my laptop after applying 12437_v2.diff.
The height of the grid is still to large. It seems that a fixed value is used (530px). I tried to change the height parameter for tbar in t3_recycler.js from "height: 530" to "height: 98%" but then the grid collapsed almost completely. I' have to admit that my experience with ExtJS is tiny and trial&error is not very effective. :(
Personally I don't like the buttons on the right side. I am used to have buttons at the bottom.
#11 Updated by Steffen Kamper over 10 years ago
indeed a problem with small screens. So i will put the buttons to the bottom bar.
As it's not possible (at least now) to calculate the correct height of the frame, i will add a setting in EM for the height, so you can adjust the height of the container there.
PS - you couldn't adjust the height in the js as it was defined twice. I restructured the code once again to have it easy for reading / modifying, will upload new patch today.