Bug #21499
closed
Update Wizard step 3: Uninstalling all new system extensions outputs "Update FAILED!"
Added by Daniel Doesburg over 14 years ago.
Updated about 13 years ago.
Description
Update Wizard step 3: Perform updates outputs "Update FAILED!".
This only occurs when I want to uninstall all "installSystemExtensions". If I uncheck all chackboxes I get those message.
And all other things are fine.
(issue imported from #M12511)
Files
Is that still a problem?
At step 3 a database connection is needed and the file localconf.php needs to be writable. If it is still a problem, please check, that both is the case.
Yes. Please try out the latest beta (4.4beta2) and let us know if still fails.
With 4.4.0b3 still the same. But only if I want to uninstall all "installSystemExtensions". If I uncheck all chackboxes I get those message. And all other things are fine. Database compare is no problem. Whole site acts as it should. Only this is a little cosmetic problem, because I can of course change all the extensions in the EM. But for newbies it's confusing
I agree with this problem. To rephrase: if you are in one of the 2 wizards that propose to install extensions (outsourced ones or news ones) and you uncheck all the boxes, then proceed with the update, the result - as displayed on the next screen - will be "Update FAILED". This is not due to any code error. It's due to the fact that performUpdate() returns FALSE when it does nothing.
The problem is that currently performUpdate() is keyed to return a boolean value, so we have only TRUE and FALSE as available return status. We would need to change that to include "skipped" status IMO. This is too late now for 4.5, but it should be done for 4.6.
Why not return TRUE, even if the user decided to install no extension?
This could be quick fix, but I would find it better to have a specific status for skipping an update. I think it's cleaner. A skipped update is not really successful. It would also make it possible to display a different confirmation message, maybe hinting at how one should be careful when skipping an update.
Of course, there should be a skipped state. However, from the user sight I would say that the wizard was successful - it did, what the user asked to do.
Skipped wizards should also remember their state and never show up again.
Both issues solved in #24583. Please test (pending)
- Target version deleted (
4.5.0)
Also available in: Atom
PDF