Project

General

Profile

Actions

Bug #21601

closed

Labels for calcAge: Singular/Plural

Added by Bernhard Kraft about 15 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Could have
Category:
-
Target version:
-
Start date:
2009-11-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The labels for the "calcAge" method can only be given in grammatical singular or plural.

So the results will be like "1 seconds" ... or "123 second" ... but correct would be "1 second" and "123 seconds".

Fix:
Add a check if the result is only "1" and use the grammatically correct singular form of the label in this case.

See attached patch

(issue imported from #M12650)


Files

0012650.diff (4.3 KB) 0012650.diff Administrator Admin, 2009-11-18 11:28
Actions #1

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change Id07a1a4ca1e598c35aff2842a1ae3012adab7cba has been pushed to the review server.
It is available at http://review.typo3.org/2787

Actions #2

Updated by Stefan Neufeind over 13 years ago

Committed a version that gets this in sync with tslib_content::calcAge()

Actions #3

Updated by Stefan Neufeind over 13 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Martin Kutschker over 13 years ago

  • Target version deleted (0)

Just a hint if someone is eager to aim higher. Some languages differ not only between one and many. See [1] for some ideas.

[1] http://developer.android.com/guide/topics/resources/string-resource.html#Plurals

Actions #5

Updated by Steffen Gebert over 13 years ago

  • Target version set to 1281
  • TYPO3 Version set to 4.6
Actions #6

Updated by Xavier Perseguers over 12 years ago

  • Status changed from Resolved to Closed
Actions #7

Updated by Ernesto Baschny over 11 years ago

  • Target version deleted (1281)
Actions

Also available in: Atom PDF