Project

General

Profile

Actions

Bug #21874

closed

addToList doesn't work any more in TSConfig

Added by Christian Lerrahn almost 15 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2009-12-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

After upgrading to TYPO3 4.3 the configuration of my RTE was broken. I found out that that as because the addToList function in my Page TS did not work any more. I file this as a core bug because I don't think that this is limited to the RTE even though this is the only place where I got into trouble.

The addToList function still seems to work in TS templates.

This did still work in 4.2.10. However, I never tested any of the betas or RCs for 4.3 with this configuration.
(issue imported from #M13076)

Actions #1

Updated by Steffen Gebert almost 15 years ago

Can confirm this. Had problems with RTE-config last week.

Hope I will find time to dig into this very soon.

Actions #2

Updated by Steffen Gebert almost 15 years ago

Christian, can you provide the code snippet, with which the problem occurs?
Are you really sure that it works before the update?
Do you also use tinymce_rte?

The problem I see for tinymce_rte is, how it includes the TS configurations (minimal, standard, full):
t3lib_extMgm::addPageTSConfig('
RTE.default.loadConfig = ' . $extConf['loadConfig'] );

Then later the loadConfig file is merged by the extension itself with the custom PageTS, but at this point there's no information, whether the custom config used ":= addToLIst()" or just simple "=" assignement.
So it doesn't add the value from addToList to the default values, but only uses the value from the custom config (e.g. this happens, if you want to add a plugin to RTE by adding it to the plugins property).

I will ask Thomas, if there are any reasons against including it by using <INCLUDE_TYPOSCRIPT>.

If you don't use tinymce, please give some more information!

Actions #3

Updated by Christian Lerrahn almost 15 years ago

Yes, I know for sure that it used to work. The reason I know it broke is because editors complained about the changed behaviour after the update.

I do not have tinymce_rte installed. This is configuration for htmlarea.

On of the code snippets that have stopped working is

RTE.default.showButtons := addToList(underline, textcolor, bgcolor, line, left, center, right, indent, outdent, fontsize, justifyfull, righttoleft, lefttoright)

but it happened in more than one place.

Actions #4

Updated by Steffen Gebert almost 15 years ago

I just checked it again and can't reproduce it (with rtehtmlarea).

rtehtmlarea adds its PageTS by setting

t3lib_extMgm::addPageTSConfig('<INCLUDE_TYPOSCRIPT: source="FILE:EXT:' . $_EXTKEY . '/res/' . strtolower($TYPO3_CONF_VARS['EXTCONF'][$_EXTKEY]['defaultConfiguration']) . '/pageTSConfig.txt">');

Does - without your addToList() - Module Info > Page TSconfig show exactly the value from EXT:rtehtmlarea/res/--your-config-/pageTSConfig.txt ?
Does it show the expected value with addToList() ?

Actions #5

Updated by Oliver Hader almost 15 years ago

I've tested this with TypoScript and TSconfig and could not reproduce.

Some example for the frontend:

page = PAGE
page.13 = TEXT
page.13 {
value = test,remove
value := addToList(blah)
value := removeFromList(remove)
}

-> returns as expected "test,blah"

Actions #6

Updated by Oliver Hader almost 15 years ago

Can you please give some more information on how to reproduce this issue?

Actions #7

Updated by Christian Lerrahn almost 15 years ago

I tried to break my fixed configuration again by reverting it to what had not worked originally. However, I did not succeed.

So, while it is mysterious that the RTE broke with the update without any change to the configuration, I cannot reproduce it any more, either. Maybe some weird caching issue? I'm very sorry about the false alarm.

Please close this report.

Actions #8

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF