Project

General

Profile

Actions

Bug #22296

closed

IS cannot not index files if absRefPrefix is set and indexExternalURLs is not

Added by Dmitry Dulepov over 14 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2010-03-18
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If config.absRefPrefix is set, indexed search will not index files. There are several problems in the code:
- all non–relative URLs are treated as external. This if indexExternalURLs is not set in the extension (!!!) properties, no files will be indexed at all
- if config.absRefPrefix is a slash, indexed search will not find any files to index. Files will be indexed only if config.absRefPrefix looks like a baseURL

The attached patch solves the issue in the following way:
- it adds several ways to detect of the file is local. Currently files are always fetched with HTTP, which is a waste of resources. There are several methods for this (absRefPrefix, absolute URL without host, current host, etc)
- it adds an additional check for local files in case of schema is present
- it avoids anchors when they present in the href at position 0

After applying the patch, indexing of files works like a charm and it does not cause any unnecessary HTTP requests.

Revisions 7782 (4.3) and 7780 (4.4)
(issue imported from #M13858)


Files

13858.diff (4.34 KB) 13858.diff Administrator Admin, 2010-03-18 14:47
13858_v3.diff (11.2 KB) 13858_v3.diff Administrator Admin, 2010-04-19 16:19
13858_v5.diff (11.5 KB) 13858_v5.diff Administrator Admin, 2010-04-20 09:49
13858_v6.diff (14.7 KB) 13858_v6.diff Administrator Admin, 2010-04-21 11:17
13858_v7.diff (8.56 KB) 13858_v7.diff Administrator Admin, 2010-04-30 12:25
13858_final.diff (15.5 KB) 13858_final.diff Administrator Admin, 2010-05-31 10:41

Related issues 4 (0 open4 closed)

Related to TYPO3 Core - Bug #20035: Crawler does not crawl though relative links in an external pageClosedJeff Segars2009-02-17

Actions
Related to TYPO3 Core - Bug #22229: External URL only indexes first pageClosedXavier Perseguers2010-03-03

Actions
Has duplicate TYPO3 Core - Bug #15444: external documents not always indexedClosedDmitry Dulepov2006-01-18

Actions
Has duplicate TYPO3 Core - Bug #19593: external documents where not indexed if the path begins with httpClosedDmitry Dulepov2008-11-11

Actions
Actions #1

Updated by Dmitry Dulepov over 14 years ago

v3 adds support for relative paths, unit tests and backpath resolving

Actions #2

Updated by Dmitry Dulepov over 14 years ago

v5 fixes behavior change in T3var processing and adds unit tests for the whole stuff

Actions #3

Updated by Dmitry Dulepov over 14 years ago

v6: more refactoring, more unit tests

Actions #4

Updated by Steffen Ritter over 14 years ago

v7 fixes uninitialized return values, thanks to Oliver Klee pointing this out

Actions #5

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF