Bug #23350

Don't show the logged-in message when I'm logged in

Added by Peter Klein about 11 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
felogin
Target version:
-
Start date:
2010-08-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

#19578 - "Don't show the logged-in message when I'm logged in"

Is not fixed, and if the solution is to build your own loginbox using TS, then the felogin extension is obsolete and shouldn't be part of the core.

So either fix the problem correctly, or remove the extension from core.

(issue imported from #M15351)


Files

felogin.patch (622 Bytes) felogin.patch Administrator Admin, 2011-03-22 17:04

Related issues

Has duplicate TYPO3 Core - Feature #19578: Don't show the logged-in message when I'm logged inClosed2008-11-06

Actions
#1

Updated by Marcel Fitzner about 11 years ago

You can remove any output from the felogin extension via the felogin template which is to be found in the extension directory, and can be copied and modified for your own customization.

Or I don't understand your problem here.

#2

Updated by Jan Schreier almost 11 years ago

think this is a duplicate of:
http://bugs.typo3.org/view.php?id=15421

the attached diff works fine in my 4.4 environment.

#3

Updated by Administrator Admin over 10 years ago

I had the same behaviour in our Typo3 4.4.5 and I debugged the felogin extension. I guess, there has been a change of the type of <i>$this->logintype</i> from boolean to string. <i>$this->logintype</i> contains a string, e.g. 'login' or 'logout', but is used as boolean in the if clause:

...
if($this->userIsLoggedIn && !$this->logintype) {
...

I fixed this with

if($this->userIsLoggedIn && $this->logintype != 'logout') {

and now the login works perfect for us.

I attached the patch in http://bugs.typo3.org/file_download.php?file_id=15577&type=bug

In version 4.5.x this part is still the same, so the patch may work there too.

#4

Updated by Xavier Perseguers over 9 years ago

  • Assignee deleted (Steffen Kamper)
  • Target version deleted (0)
  • TYPO3 Version set to 4.5
#5

Updated by Gerrit Code Review about 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22728

#6

Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22728

#7

Updated by Gerrit Code Review about 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22728

#8

Updated by Wouter Wolters almost 7 years ago

  • Status changed from Under Review to New
  • Is Regression set to No
#9

Updated by Riccardo De Contardi almost 4 years ago

  • Status changed from New to Closed

I close this ticket for now; the patch has been abandoned and I think that everything is already working out of the box (I tested with 8.7.x but I am pretty sure that it works too on 7.6.x and 6.2.x or even with older versions).

I performed the following tests:

Prerequisites

- create a sysFolder where to store FE users (ID=8)
- create an usergroup
- create a user, assign the usergroup and set an username and a password

Test 1 - add login form as content of a page

- create a page
- add the felogin plugin
- configure it at the minimum, that is assign the sysfolder
- check the checkbox Disable redirect after successful login, but display logout-form
- go to the page where the plugin has been added
- try to login

Test Results:

After the successful login, the logout form is shown.

Test 2 - add login form via TypoScript

- I removed the previously created content element (just to be sure that I always have only 1 login form)
- in the TS Setup I added a mimimal configuration:

page.1 <  plugin.tx_felogin_pi1
page.1{
  storagePid=8
  preserveGETvars = all
  showForgotPasswordLink = 0
  showLogoutFormAfterLogin = 1
}

- go to a page
- try to login

Test Results:

After the successful login, the logout form is shown.

Conclusion

As I said, it seems IMO that everything works as expected, therefore I close this issue.
If you think that this is the wrong decision or that I have misunderstood the problem or that a different test should be performed, please reopen this issue or open a new issue with a reference to this one; please add also a detailed step-by-step procedure that should be followed to reproduce the issue. Thank you.

Also available in: Atom PDF