TYPO3 Core

Hi Julian,

Sounds valid - however SwiftMailer docs also seem to have some issues ;)

You probably read this code:

class Swift_SmtpTransport extends Swift_Transport_EsmtpTransport
{

  /**
   * Create a new SmtpTransport, optionally with $host, $port and $security.
   * @param string $host
   * @param int $port
   * @param int $security
   */
  public function __construct($host = 'localhost', $port = 25,
    $security = null)

However $security is directly passed to setEncryption() of the parrent class Swift_Transport_EsmtpTransport, which is defined as following:

  /**
   * Set the encryption type (tls or ssl)
   * @param string $encryption
   */
  public function setEncryption($enc)
  {
    $this->_params['protocol'] = $enc;
    return $this;
  }

Thus the PHPdoc seems to be wrong and should be "string" (options tls and ssl).

Should the user be able to choose between TLS and SSL? I think TLS should be deployed everywhere, shouldn't it? Otherwise we probably have to change the checkbox to a string field to choose between tls an ssl.

I've now reportet the bug to the SwiftMailer guys:
http://swiftmailer.lighthouseapp.com/projects/21527-swift-mailer/tickets/177-wrong-phpdoc-comment-for-swift_smtptransport__construct

So.. do we need a choise for tls/ssl or is just unencrypted or tls instead fine?

In my opinion it suffices to have one properly working encryption. So there is no need to have a choice.

It gets stranger:
in Swift_Transport_EsmtpTransport the member $_params is declared as:
private $_params = array(
'protocol' => 'tcp',
'host' => 'localhost',
'port' => 25,
'timeout' => 30,
'blocking' => 1,
'type' => Swift_Transport_IoBuffer::TYPE_SOCKET
);
So the protocol is initialized as 'tcp'.

It feels as if we need to provide either NULL (default value in constructor) or one of the protocols 'tls' / 'ssl' as $security. But NULL would also remove the 'tcp' protocol...

Review pending:
master: https://review.typo3.org/1127
4-5: https://review.typo3.org/1132

Merged:
master: da2373d0199c7cd4ea85f633043856a55408f784
4-5: 443dec1fe0d97b67b1af69247a579e4074277a0b