Project

General

Profile

Actions

Bug #24992

closed

List module - backend layout - moving content elements

Added by Tomas Mrozek about 13 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-02-09
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When moving a content element in the List module by clicking on the "Re-position content element" icon, an user is presented with the old 4 columns instead of columns that would represent the newly introduced backend layout as it is appearing in the Page module.

(issue imported from #M17529)


Files

17529.diff (8.22 KB) 17529.diff Administrator Admin, 2011-02-21 22:35
17529v2.diff (8.07 KB) 17529v2.diff Administrator Admin, 2011-02-22 18:18

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #42457: Backend layout & page content wizardClosed2012-10-28

Actions
Actions #1

Updated by Ernesto Baschny about 13 years ago

Indeed a missing feature.

Actions #2

Updated by Tomas Mrozek about 13 years ago

I strongly disagree. This is not "a missing feature" but a BUG that should be fixed in 4.5. Notice that with the new backend layouts there is now no "visual mode" for moving content elements in 4.5 as:

1) There's no drag & drop Page module.
2) Moving in the List module doesn't work.

The only way of changing column position is a "textual mode" = column select box in the content editing form. An editor therefore relies on the column title. With complicated layouts this is really cumbersome.

One of the points of backend layouts was to introduce more complicated layouts in the Page module. It seems to be failing spectacularly. Considering that 4.5 is an LTS version, I'm getting goose bumps thinking that this stays unfixed.

Actions #3

Updated by Ernesto Baschny about 13 years ago

Relax, don't need to get goose bumps because of this! :)

You could try to provide a patch to fix that, and we can talk about it. Would that be possible?

Actions #4

Updated by Tomas Mrozek about 13 years ago

I can't relax about that. :-) The new backend layouts are the best thing about v4.5 but having this bug means to give up on this new feature because you simply cannot have anything malfunctioning like this in a production website.

I'll have a look at how this stuff works but I cannot promise I'll be able to come up with a patch. I'm afraid it's a bit out of my league.

Actions #5

Updated by Jo Hasenau about 13 years ago

Actually this is already on my list, since there are several places especially in the list module that currently do not respect the columns and labels provided by the selected grid.

IMHO some of them are definitely to be considered as bugs, but i.e. the drag & drop is a feature so this will have to wait until 4.6

The problem with the labels is not restricted to grid records only but due to the fact that the itemsProcFunc is not taken into account while generating labels for select items. So you will only get the TCA default labels or no label at all. This is an annoying bug that should be fixed in 4.5 as well but I will file a separate BT report for it.

Actions #6

Updated by Jo Hasenau about 13 years ago

BTW: The list module does not respect any additional colPos values while moving elements, even if you set them in TSconfig via addItems.

So this is not just a grid related bug as well.

Actions #7

Updated by Tomas Mrozek about 13 years ago

I agree that some things like drag & drop can wait. It would be handy to have it but the lack of it is not breaking any functionality.

Actions #8

Updated by Jo Hasenau about 13 years ago

itemsProcFunc is now in the BT as well: #25113

Actions #9

Updated by Jo Hasenau about 13 years ago

Attached patch will add the missing columns abd labels to the position table. Additionally the table will represent the grid layout of the selected record if any.

Please test if this works for you.

Actions #10

Updated by Tomas Mrozek about 13 years ago

It looks brilliant but there seems to be a bug: the columns in the view don't correspond to the layout, meaning that:

1) Content is moved to wrong columns.
2) Content that is already on the page where the content element is being moved appears in wrong columns (unlike in the Page module where it's correct).

TESTED LAYOUT:

backend_layout {
colCount = 4
rowCount = 3
rows {
1 {
columns {
1 {
name = Top
colspan = 4
colPos = 4
}
}
}
2 {
columns {
1 {
name = Left
colPos = 1
}
2 {
name = Middle
colspan = 2
colPos = 0
}
3 {
name = Right
colPos = 2
}
}
}
3 {
columns {
1 {
name = Bottom
colspan = 4
colPos = 3
}
}
}
}
}

When moving a content element, and trying to place it in the "Middle" column (colPos=0), the content ends up in the "Top" column (colPos=4).
Looking at the source code, the links in the...

1) ..."Top" colum have "[colPos]=3".
2) ..."Left" colum have "[colPos]=1".
3) ..."Middle" colum have "[colPos]=4".
4) ..."Right" colum have "[colPos]=0".
5) ..."Bottom" colum have "[colPos]=2".

Actions #11

Updated by Jo Hasenau about 13 years ago

Thanks for the feedback. I will take a look at it tonight.

Actions #12

Updated by Tomas Mrozek about 13 years ago

I had a look and the mess-up is happening in the method printContentElementColumns() of the class t3lib_positionMap.

The method creates an array (var $lines) in which the keys are not colPos numbers.

I don't know though what would be the best fix having backward compatibility in mind.

Actions #13

Updated by Tomas Mrozek about 13 years ago

I've just had more time to play with it so here comes a patch suggestion for your consideration Jo.

Actions #14

Updated by Jo Hasenau about 13 years ago

sorry - I wasn't able to check the stuff last night due to a client who is launching a new website today. Will try to have a look at it tonight.

Actions #15

Updated by Ernesto Baschny about 13 years ago

We will be packaging 4.5.1 in a couple of minutes.

But we will have a 4.5.2 some time soon, so no need to over-rush. It's important to get it fixed, but there are already tons of fixes we will package today. So keep it on your list please!

Actions #16

Updated by Jo Hasenau about 13 years ago

Will do - maybe we can plan 4.5.2 stuff in Berlin. - CU there

Actions #17

Updated by Jo Hasenau about 13 years ago

I had some time in the train on my way back home today so I was able to fix it completely (including labels for unassigned columns) - will come up with a patch until tomorrow since I have to separate it from the other grid related patches first.

Actions #18

Updated by Andreas Wolf about 13 years ago

Merged to master in 9edcbf86d075d0e267a6e8fdb17eadd2def0fdc1.

Actions #19

Updated by Andreas Wolf over 12 years ago

  • Status changed from Resolved to Under Review

This is not fixed in 4.5 - see https://review.typo3.org/#change,5383

Actions #20

Updated by Chris topher over 12 years ago

  • Target version changed from 4.6.0 to 4.6.1
Actions #21

Updated by Chris topher over 12 years ago

  • Target version changed from 4.6.1 to 4.6.2
Actions #22

Updated by Xavier Perseguers about 12 years ago

  • Assignee deleted (Andreas Wolf)
  • Target version deleted (4.6.2)
Actions #23

Updated by Wouter Wolters almost 10 years ago

  • Status changed from Under Review to Closed
  • Is Regression set to No

Long time ago abandoned

Actions

Also available in: Atom PDF